Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stitching serialization invalid json #2024 #1972 on v10 #2091

Conversation

erwan-joly
Copy link
Contributor

same as #2086 for v10

@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2020

SonarCloud Quality Gate failed.

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 2 Security Hotspots to review)
Code Smell A 329 Code Smells

79.7% 79.7% Coverage
1.4% 1.4% Duplication

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@erwan-joly
Copy link
Contributor Author

@michaelstaib are the tests expected to fail ? this is exactly the same code in #2086

@michaelstaib
Copy link
Member

Sonar, yes.... since it is pushing the code changes against the sonar 11 result. Do not worry about that. This is gonna be one of the last updates to the 10 core.

@michaelstaib michaelstaib merged commit d262d2f into ChilliCream:version_10_0_0_master Jun 28, 2020
@michaelstaib
Copy link
Member

I have to do one more fix and for 10 and then I will create a preview ... .are you on our slack channel?

@erwan-joly erwan-joly deleted the FixStitchingSerializationIntegerv10 branch June 28, 2020 11:52
@erwan-joly
Copy link
Contributor Author

I am now Erwan Joly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants