Bugfix/querysyntaxserializer #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this one was fixed on 11 ... let me check ... |
|
Cool, could you please accept pr for version 10?
pon, 23. nov 2020. 12:37 Michael Staib <notifications@github.com> je
napisao/la:
…
https://github.com/ChilliCream/hotchocolate/blob/03c7290f5a5d016536b98cf525b3bce68603928f/src/HotChocolate/Language/src/Language.SyntaxTree/Utilities/SyntaxSerializer.QuerySyntax.cs#L5
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2646 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKFDMGZ5KJPXLDVDE7LAJX3SRJCRJANCNFSM4T7LDNMA>
.
|
|
Sure, but it needs tests showing that the fix works. One test showing serialization with name and variables works and one that it works for the short-hand syntax and another one that shows it works when the name is omitted but variables are defined. Once we have tests I merge it and create a new 10.5.5 |
michaelstaib
approved these changes
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serialization of querydocument without name but with variables omits variables.
persisted queries can't use serialized document, exception "message": "The following variables were not declared: productId." is thrown