Publish docs to GitHub pages #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossmotley
force-pushed
the
ross/publish-to-github-pages
branch
from
358866d to
3970d0c
Compare
whitequark
approved these changes
May 24, 2024
There was a problem hiding this comment.
LGTM. The reason "upload artifact" is a separate step is that then you can download it as a zip from e.g. a PR and test locally. There is also publish-docs-dev which publishes it to a GH branch in the PR author's repo, though that requires a little bit of setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish the docs to the new chipflow.github.io GitHub pages repository.