Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploader failing in Safari with "block all cookies" preference #4189

Closed
ghost opened this issue Jun 15, 2021 · 3 comments
Closed

Uploader failing in Safari with "block all cookies" preference #4189

ghost opened this issue Jun 15, 2021 · 3 comments
Labels
Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor UI non-trivial UI changes, that might need discussion

Comments

@ghost
Copy link

ghost commented Jun 15, 2021

Describe the current behavior

There seems to be a compatibility problem with Safari and MobileSafari and the new uploader. After upgrading to Peertube 3.2.1, I got a user reporting failed uploads from their iOS device. I tried reproducing the problem on desktop Safari and it seems to be similar if not the same there.

Steps to reproduce:

  1. Use Safari
  2. Log in
  3. Upload a video

Describe the expected behavior

Video starts upoading

Additional information

Upload stays at 0%, error in Javascript console.
I ran it again with the debugger enabled, to get a better backtrace:

Screen Shot 2021-06-15 at 6 45 29 AM

I'll look into this some more but this seemed like enough to submit a bug report in case someone else already recognizes this issue. I'm not yet sure what safari means by "insecure" in this context, as all the resources involved are https from the same domain.

  • PeerTube instance:

    • URL: diode.zone
    • version: 3.2.1
    • NodeJS version:
    • Ffmpeg version:
  • Browser name, version and platforms on which you could reproduce the bug: Safari 14.1.1

  • Link to browser console log if relevant:

  • Link to server log if relevant (journalctl or /var/www/peertube/storage/logs/):

@ghost
Copy link
Author

ghost commented Jun 15, 2021

Actually the browser had a preference I'd forgotten about, it was set to "Block all cookies", which results in this unhelpful failure in the uploader code. I'm updating this bug to reflect that issue rather than the iOS problem, as I'm not sure if that's the same bug and I don't have additional information from that user.

@ghost ghost changed the title Uploader failing in iOS and desktop Safari with SecurityError in local storage Uploader failing in Safari with "block all cookies" preference Jun 15, 2021
@kukhariev
Copy link
Contributor

Hi, @scanlime.
Does updating ngx-uploadx to version 4.1.2 fix this issue?

@Chocobozzz Chocobozzz added Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor UI non-trivial UI changes, that might need discussion labels Jun 25, 2021
@Chocobozzz
Copy link
Owner

Thanks @kukhariev, I confirm than 4.1.2 seems to fix this issue (see 2b58ca7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Confirmed bug, at least replicated once by another contributor UI non-trivial UI changes, that might need discussion
Projects
None yet
Development

No branches or pull requests

2 participants