Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify notifications for the pre-check-less case scenario #28

Closed
mkaczanowski opened this issue Dec 18, 2024 · 0 comments · Fixed by #31
Closed

Modify notifications for the pre-check-less case scenario #28

mkaczanowski opened this issue Dec 18, 2024 · 0 comments · Fixed by #31
Assignees
@sin3point14
Labels
bug Something isn't working

Comments

@mkaczanowski
Copy link
Contributor

TL;DR

In the current code, if the pre-checks are skipped and the upgrade is executed via upgrade-info.json path, there are no (or just one) slack notifications.

That is confusing to network operator as he doesn't see the upgrade happening.

It would be great to add slack notifications to performUpgrade so that:

  1. we know at the entry the upgrade code path has been triggered
  2. major steps of the upgrade have notifications (e.g when the version is replaced in the env file etc)
@mkaczanowski mkaczanowski added the bug Something isn't working label Dec 19, 2024
@sin3point14 sin3point14 self-assigned this Dec 19, 2024
@sin3point14 sin3point14 mentioned this issue Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sin3point14 sin3point14

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add better notifications for upgrade process ChorusOne/blazar
2 participants
@mkaczanowski @sin3point14