Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tweaks]: Edge Removal x86 Compat #2586

Closed
wants to merge 1 commit into from
Closed

[tweaks]: Edge Removal x86 Compat #2586

wants to merge 1 commit into from

Conversation

psyirius
Copy link
Contributor

Edge Removal x86 Compatibility (TWEAKS)

Type of Change

  • Bug fix

Issue related to PR

Additional Information

Pushing this from handheld device. So, sorry for the code dup. If Anyone have time rewrite it more efficient.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@psyirius
Copy link
Contributor Author

@MyDrift-user It might leave the shortcuts in user and public desktops.

Could you add some lines to strip that out?

@psyirius psyirius changed the title [TWEAKS]: Edge Removal x86 Compat [tweaks]: Edge Removal x86 Compat Aug 21, 2024
@ChrisTitusTech ChrisTitusTech force-pushed the main branch 2 times, most recently from 7805fe4 to cfb9edb Compare August 26, 2024 22:01
@ChrisTitusTech
Copy link
Owner

Man I feel bad as I've hit like 3 of your last PRs with the close button.

Sadly, 32-bit support is going away and is Windows 10 Only. So adding this will just add to the code base and not needed imo.

As of September 30, 2024, Microsoft will no longer provide product upgrades or reinstallments for 32-bit versions of Windows 10

@psyirius
Copy link
Contributor Author

psyirius commented Aug 30, 2024

Man I feel bad as I've hit like 3 of your last PRs with the close button.

Sadly, 32-bit support is going away and is Windows 10 Only. So adding this will just add to the code base and not needed imo.

As of September 30, 2024, Microsoft will no longer provide product upgrades or reinstallments for 32-bit versions of Windows 10

Alright,
I feel my PR's doesn't align with the people working in this project and the vision of this project!
No more PR's from me!

For the love of God, @ChrisTitusTech please open your kitty eyes to read what's there on the PR thread other than the title before merging it!

PS: It's sad that poor people who still want to make use of their old hardware cannot use this tool!

@alturic
Copy link

alturic commented Aug 30, 2024

You could always fork it to make an x86-specific version if it's going to start causing issues. Heck, this isn't even a CTT-specific issue, it's Microsoft.

@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Edge removal script doesn't work with Win10 32bit
4 participants