Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle build with tweak version fails #831

Closed
ygorelik opened this issue Oct 24, 2018 · 1 comment
Closed

Bundle build with tweak version fails #831

ygorelik opened this issue Oct 24, 2018 · 1 comment

Comments

@ygorelik
Copy link
Collaborator

Expected Behavior

The bundle version should accept tweak number.

Current Behavior

When bundle version contains tweak, (ex.: 0.1.5-post1) the build fails due to cmake error or Python exception:

Example 1: version = 0.1.6-post1

CMake Error at CMakeLists.txt:3 (project):
  VERSION "0.1.6-post1" format invalid.

Example 2: version = 0.1.6.1

Traceback (most recent call last):
  File "./generate.py", line 468, in <module>
    output_directory = (generator.generate(options.bundle))
  File "/home/ygorelik/ydk-0.7.3/ydk-gen/ydkgen/__init__.py", line 89, in generate
    return self._generate_bundle(description_file)
  File "/home/ygorelik/ydk-0.7.3/ydk-gen/ydkgen/__init__.py", line 110, in _generate_bundle
    curr_bundle, all_bundles = resolver.resolve(tmp_file)
  File "/home/ygorelik/ydk-0.7.3/ydk-gen/ydkgen/resolver/bundle_resolver.py", line 297, in resolve
    root = Bundle(bundle_file, self.cached_models_dir, self.iskeyword)
  File "/home/ygorelik/ydk-0.7.3/ydk-gen/ydkgen/resolver/bundle_resolver.py", line 227, in __init__
    super(Bundle, self).__init__(data['bundle'])
  File "/home/ygorelik/ydk-0.7.3/ydk-gen/ydkgen/resolver/bundle_resolver.py", line 83, in __init__
    self._version = Version(*tuple(data['version'].split('.')))
TypeError: __new__() takes exactly 4 arguments (5 given)

Steps to Reproduce

In the bundle profile set version to have a tweak value.

System Information

YDK 0.7.3, C++ bundle.

@ygorelik
Copy link
Collaborator Author

ygorelik commented Feb 1, 2019

Resolved with #864

@ygorelik ygorelik closed this as completed Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant