Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Task and TaskCancel protocol #56

Open
sharpener6 opened this issue Feb 6, 2025 · 1 comment
Open

Revisit Task and TaskCancel protocol #56

sharpener6 opened this issue Feb 6, 2025 · 1 comment
Assignees

Comments

@sharpener6
Copy link
Collaborator

sharpener6 commented Feb 6, 2025

So in the current design, the task execution and cancel is not very ideal, which caused a few bugs:

Originally, in the very first version, all the tasks can be canceled on the worker side, even the one that is running, we achieved that by killing the process if that's the case, which means the ack for task cancel will be always success if task exists, and it doesn't need wait ack after task cancel happened, in this issue, we are going to formalize the task state changing, especially task cancel, so it can pave the road for following bugs:

  1. balancing tasks use TaskCancel, without this proper ack mechanism, it cannot be solved properly Fixes balancing issues under heavy load. #51
  2. when graph run get canceled, the graph tasks are not cleaned properly
  3. the bug with NotFound issue Scheduler incorrectly returns a task not found error #45

I will upload the task state machine in following post under this issue

@sharpener6 sharpener6 self-assigned this Feb 6, 2025
@yzard
Copy link

yzard commented Feb 7, 2025

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants