-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate filters to use units summary #530
Comments
We'll have to consider this for bedroom and rent filters as well (and potentially more), so ideally we'll have a general solution for whether to use the units or the units summary table for queries. |
As kind of a hack, we've been using E.g. if |
To make this less hacky (and more contributeable upstream), I think we should add a column to the |
Ok, pivoting on this a bit. After discussing with @willrlin I think it's likely that Exygy will deliver the link between the units and summary table before we wind up getting any units data, so it makes more sense to simplify this and just migrate all the filters to check summary data. |
The availability filter currently looks up the number of available units in the Units Summary table. This may not work for listings that don't use the unit summary table, and instead include every unit in the units table.
It seems like we have two options to make this work:
The text was updated successfully, but these errors were encountered: