Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bbox, date, and cloud cover for patch level embeddings #168

Closed
yellowcap opened this issue Feb 29, 2024 · 10 comments
Closed

Bbox, date, and cloud cover for patch level embeddings #168

yellowcap opened this issue Feb 29, 2024 · 10 comments
Assignees

Comments

@yellowcap
Copy link
Member

yellowcap commented Feb 29, 2024

To further enable patch level embeddings, two tasks:

  1. Add functionality so that the predict.py routine outputs patch level embedding bounding box.
  2. Track cloud coverage in each patch for quality filtering when using the embeddings
  3. Include date stamp in the embedding database as well

This ticket is to track your request for patch level embeddings for bboxes @danhammer

@yellowcap yellowcap changed the title Bbox and cloud cover for patch level embeddings Bbox, date, and cloud cover for patch level embeddings Mar 1, 2024
@lauracchen
Copy link
Member

Hi @yellowcap do you have a sense of when this might be possible by? We're hoping to be able to fully work with patch-level embeddings and further explore their usefulness as soon as possible to inform next steps for our app development!

@yellowcap
Copy link
Member Author

Its in progress, if we don't hit an unexpected roadblock, it should be done this week.

@lauracchen
Copy link
Member

That's great to hear, thank you!

@lauracchen
Copy link
Member

hi @yellowcap any update here or any roadblocks? Maybe @brunosan can help out if there's any blockers.

@brunosan
Copy link
Member

not sure if already in scope, but also the option to not average the band groups.

@yellowcap
Copy link
Member Author

We made good progress, I will review #172 today and hopefully we can merge that soon.

@lillythomas
Copy link
Contributor

Yes @lauracchen I'm incorporating Daniel and Wei Ji's comments today, so #172 should be merged by Monday morning.

@lillythomas
Copy link
Contributor

@lauracchen patch level bounding box, date and cloud cover information have been addressed in #172 and #184 respectively, both of which are merged into main now. The notebooks to demonstrate are docs/tutorial_digital_earth_pacific_patch_level.ipynb and docs/patch_level_cloud_cover.ipynb.

They use the Digital Earth Pacific data (#140) to focus the examples.

@lauracchen
Copy link
Member

thank you so much!! @lillythomas

@yellowcap
Copy link
Member Author

Closing this as done, let's reopen or make a new ticket for additional questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants