Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plastic bottles can be put in gallon jugs #40130

Closed
RedShakespeare opened this issue May 4, 2020 · 9 comments
Closed

Plastic bottles can be put in gallon jugs #40130

RedShakespeare opened this issue May 4, 2020 · 9 comments
Labels
Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Items: Containers Things that hold other things (S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@RedShakespeare
Copy link
Contributor

RedShakespeare commented May 4, 2020

Describe the bug

Plastic bottles and many more items can be put in containers like gallon jugs with large volume but rather smaller bottleneck caliber (in real world).

Steps To Reproduce

  1. Make a player with a gallon jug wielded.
  2. Spawn a plastic bottle and drop it on the ground.
  3. Try to pick up the bottle.
  4. The bottle will be inside the jug.

Expected behavior

There might be some more attributes which decides which items can be put in certain containers and which not.

Screenshots

image

Versions and configuration

  • Game Version: 0.E-1713-gd15c896
  • Mods: dda and any other mods
@ZhilkinSerg ZhilkinSerg added (S1 - Need confirmation) Report waiting on confirmation of reproducibility Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Items: Containers Things that hold other things labels May 4, 2020
@mrkybe
Copy link
Contributor

mrkybe commented May 4, 2020

At least with those really thin-plastic poland springs water bottles, you could probably get them into a gallon jug by twisting them up. I don't imagine getting them out will be very practical though.

@Wolfechu
Copy link

Wolfechu commented May 4, 2020

Had it happen to me too; inadvertent fumbling with the new system left me with a bottle of forest honey inside a gallon jug; then somehow, I got the bottle out but the honey stayed inside the jug. I'm now available to do conjuring tricks at children's parties ;)

@woutershep
Copy link
Contributor

2020-05-04-134355_300x799_scrot
:D

@Lamandus
Copy link
Contributor

Lamandus commented May 4, 2020

grafik

@ennob
Copy link
Contributor

ennob commented May 12, 2020

Maybe containers could have a stat that keeps track of the maximum size of individual objects that can be put in them, independent form the maximum storage capacity.

@Lamandus
Copy link
Contributor

Maybe containers could have a stat that keeps track of the maximum size of individual objects that can be put in them, independent form the maximum storage capacity.

we already got that. with Item_lengh and max_lengh.

@Zireael07
Copy link
Contributor

@Lamandus: Item length implementation postdates this issue. Now that item length PR is merged, I believe this issue can be closed?

@Lamandus
Copy link
Contributor

@Lamandus: Item length implementation postdates this issue. Now that item length PR is merged, I believe this issue can be closed?

I am fully on your side here, but I am not the OP.

@RedShakespeare
Copy link
Contributor Author

Fixed in #40186 & #40214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Inventory / AIM / Zones Inventory, Advanced Inventory Management or Zones Items: Containers Things that hold other things (S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
Development

No branches or pull requests

8 participants