Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default datadir does not obey the PREFIX makeflag. #40140

Closed
gottaeat opened this issue May 4, 2020 · 3 comments
Closed

default datadir does not obey the PREFIX makeflag. #40140

gottaeat opened this issue May 4, 2020 · 3 comments

Comments

@gottaeat
Copy link

gottaeat commented May 4, 2020

Describe the bug

binary of the latest stable release looks for the game data under /usr/share/cataclysm-dda even if PREFIX is set to something other than /usr during make.

Steps To Reproduce

  1. build and install with:
    make ZLEVELS=1 RELEASE=1 LOCALIZE=0 BACKTRACE=0 USE_XDG_DIR=1 PREFIX="/opt/cataclysm-dda-0.e"
  2. simply run the catacylsm under $PREFIX/bin/.

Expected behavior

for the game to look under $(PREFIX)/share/catacylsm-dda instead of /usr/share/catacylsm-dda by default.

Versions and configuration

  • OS: x86_64 musl linux host
  • Game Version: 0.E (source obtained from here)
  • Graphics version: ncurses
  • Ingame language: english but not relevant
  • Mods loaded: none
@gottaeat
Copy link
Author

gottaeat commented May 4, 2020

interestingly, i rebuilt using with these flags instead, and it automatically looked at /opt/cataclysm-dda-0.e/share/cataclysm-dda for game data:

make \
 LUA=1         \
 ASTYLE=0      \
 ZLEVELS=1     \
 RELEASE=1     \
 LOCALIZE=0    \
 BACKTRACE=0   \
 USE_XDG_DIR=1 \
 LUA_BINARY="/usr/bin/lua5.2"    \
 PREFIX="/opt/cataclysm-dda-0.e"

@anothersimulacrum
Copy link
Member

anothersimulacrum commented May 4, 2020

This is the relevant area of code main.cpp:148-179.

@gottaeat
Copy link
Author

gottaeat commented May 4, 2020

i've rebuilt once more with my original makeflag setup and it seems that i messed something up because it does look at the correct path for datadir.

i sincerely apologize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants