Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-drink sometimes prefers alcohol and bleach over clean water; bleach shouldn't be comestible #40290

Closed
kaeroku opened this issue May 7, 2020 · 5 comments
Labels
Good First Issue This is a good first issue for a new contributor Items: Food / Vitamins Comestibles and drinks Items / Item Actions / Item Qualities Items and how they work and interact stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing

Comments

@kaeroku
Copy link
Contributor

kaeroku commented May 7, 2020

Game version: 0.E-1272-g3bdcb87

Operating system: Win 7 Home 64-bit

Tiles or curses: ChestHole16

Mods active: Disable NPC Needs, Stats Through Skills, No Fungal Creatures,

Expected behavior

Auto-drink won't drink bleach and won't choose non-clean-water beverages over clean water.

Actual behavior

Auto-drink will include bleach as an option if it is in range of auto-drink zones and will sometimes choose non-clean-water beverages over clean water.

Steps to reproduce the behavior

Launch game. Set auto-drink zone. Include clean water and other alcoholic and bleach items. Engage in a long activity like crafting that auto drinks. Repeat with various stacks of liquids and clean water.

@DillonSimeone
Copy link
Contributor

image

This is what happened to the poster. Autodrink forced him to drink himself to death!

@ZhilkinSerg
Copy link
Contributor

Related to #14855
Related to #14851

@ZhilkinSerg ZhilkinSerg added <Suggestion / Discussion> Talk it out before implementing Good First Issue This is a good first issue for a new contributor Items / Item Actions / Item Qualities Items and how they work and interact Items: Food / Vitamins Comestibles and drinks labels May 7, 2020
@MadmanMartian
Copy link

From looking into this, I'm not sure it was autodrink that caused this to happen, but autoeat.

Autodrink checks for quenching to be greater than 15 points, which fancy hobo only gives 4 points.
However, Autoeat checks if kcal gained from eating is greater than 50, which fancy hobo gives 52 kcal.

@stale
Copy link

stale bot commented Jun 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jun 20, 2020
@stale
Copy link

stale bot commented Jul 20, 2020

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this as completed Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue This is a good first issue for a new contributor Items: Food / Vitamins Comestibles and drinks Items / Item Actions / Item Qualities Items and how they work and interact stale Closed for lack of activity, but still valid. <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

4 participants