Weekly Digest (3 May, 2020 - 10 May, 2020) #40403

weekly-digest · 2020-05-10T02:21:34Z

Here's the Weekly Digest for CleverRaven/Cataclysm-DDA:

ISSUES

Last week 309 issues were created.
Of these, 180 issues have been closed and 129 issues are still open.

OPEN ISSUES

💚 #40397 Build #10644 - Item on drop issue, by CrankyUnicorn
💚 #40396 Clarify 'make install PREFIX' for Linux., by rickumali
💚 #40395 Character's notebook [feature] [request for comments] , by matt32106
💚 #40394 Taurus Spectrum magazine is too small for Ankle Ammo Pouch, by voidus
💚 #40393 Animal tying kills backpack, by DeclanFrost
💚 #40392 Z level integration and Movement overhaul, by Ofthefog
💚 #40391 mall cleanup part 3, by curstwist
💚 #40390 Disallow dup json comments, by jbytheway
💚 #40388 Add a coverage value to the firefighter belt, by matt32106
💚 #40387 Reduce calorie message spam to once every 12 hours, by CodeBandit
💚 #40386 Full Butchery using a Steel Boom, by JovialEvil
💚 #40385 Invalid terrain id error when moving to/off movement-slowing vehicle tiles, by Miner239
💚 #40384 Migrate message log UI and NPC trade UI to ui_adaptor, by Qrox
💚 #40382 [CR] Bugfix/cannot reload charged items, by mft-dev
💚 #40379 Magazines not stacking by their ammo count, by lordmatiz
💚 #40374 NPCs never have items to give when asked., by kaeroku
💚 #40373 Autoclave pouches sometimes cause avatar_action error and then get deleted, by Testudo-Cultu
💚 #40371 Convert islot_seed to generic_factory, by anothersimulacrum
💚 #40370 Antiseptic disappears when used more than once., by DeclanFrost
💚 #40369 Filling Tanks Maxes Capacity, by TheMurderUnicorn
💚 #40365 [BUG] [U]nloading a container from a container will make a duplicate and then crash the game if you try to unload it again, by AGasCanister
💚 #40364 Ammo pouch more problems., by Katanasoul91
💚 #40363 Aftershock: Sterile Crafted CBMs, by TheDarkMaster13
💚 #40362 Add a PoolWater to Connects_to and update JSON_INFO, by sah4001
💚 #40361 Create crafting recipes for roller blades and skates, by LyleSY
💚 #40360 Implement requirement for manual install of CBMs, by Fris0uman
💚 #40353 Addtional NPC Dialogue - Patch 2, by TheCaledonian
💚 #40352 "get prospectus" mission can't find/make mission target, by GGgatherer
💚 #40351 rework herbivore mutation chain, by enaantd
💚 #40349 [WIP] Allow remote unfolding of folded carts and the likes, by Pupsi-Mupsi
💚 #40343 Cheese spread makes stuff disappear, by JerryTheCool
💚 #40342 Animate tiles marked as animated in tile_config.json, by verate
💚 #40339 Gallon Jug Woes, by drachs
💚 #40331 Pickaxe stamina and fatigue, by TheDarkMaster13
💚 #40328 Add test spells (json) and spell tests (cpp), by wapcaplet
💚 #40321 Restore variable encumbrance, by jbytheway
💚 #40320 improve containers.json, by Jerimee
💚 #40319 Objects stack with unrelated objects, by BenlyAZ
💚 #40318 (0.E): when wearing CRIT arm and leg guards and wielding non-block weapon, I block everything with my leg guards, by Adomatic
💚 #40317 Activated items disappear from inventory, by Drew4484
💚 #40315 Unloading or Reloading items like (misc repair kit, gas mask, or sewing kit) result in none items and nothing being reloaded Respectively, by DramaticHotDog
💚 #40312 Tools that are containers can disappear when stacking wrong, by Psiclops
💚 #40311 Items not shown in inventory, by enaantd
💚 #40310 Containers and contents separated in inventory screen, by Psiclops
💚 #40307 Kitchen unit in vehicle not considered "hot plate" while crafting, by Psiclops
💚 #40306 Coal can be "Cut up" into wood, by Mrzjadacz
💚 #40299 Define pockets for all integral magazines, by ymber
💚 #40295 Add pocket data to all magazines, by ymber
💚 #40293 Dropping magazines from multidrop menu (sometimes) causes crash., by Sumguy62
💚 #40290 Auto-drink sometimes prefers alcohol and bleach over clean water; bleach shouldn't be comestible, by kaeroku
💚 #40289 Automining: Doesn't stop mining when answering YES at the prompt to do so., by Malkeus
💚 #40284 Gorging penalties, by Ramza13
💚 #40281 Container unload on floor can hang, by Adomatic
💚 #40275 Oxyacetylene cannot be crafted, by SSpook
💚 #40274 standardize zines (books, not ammo), by Jerimee
💚 #40273 (E)at menu closes after consuming one item, by mopb3
💚 #40271 adjust insert menu to support multiple items, by KorGgenT
💚 #40270 [WIP] Refactor player hardcoded effects and include tests, by wapcaplet
💚 #40269 Electric Firestarter Not Consuming Battery Charges, by Mallowdust
💚 #40268 [BUG] Eating or drinking from a container crashes the game, by AGasCanister
💚 #40266 Prevent wearing multiple Normal Eyes gear., by Moxanity
💚 #40265 Containers within other containers will show the user that they have more free space than actually available, by Resok
💚 #40263 Gun volume audit for 7.62x39 x54, by LaVeyanFiend
💚 #40262 Advanced Inventory: Move all to player freezes game., by throttlekitty
💚 #40258 Content - Toiletry Bag, by LambdaSix
💚 #40257 Inventory screen swaps from nested back to category format upon reopening, by gisaku33
💚 #40256 Add log messages for damage over time, by KorGgenT
💚 #40250 "Zombie kill station" map extra, by Night-Pryanik
💚 #40249 You can't shoot over quarterpannels, by Mrzjadacz
💚 #40242 bugfix_line_spell: prevent narrow line spells from being stopped early, by OrenAudeles
💚 #40241 Regular crashes on 0.E-924-gcba, by NobodyWorthwhile
💚 #40240 Holstering/Storing items that are too large destroys them, by Dendygaar
💚 #40235 WIP Refridgerated Tank Fix, by Maleclypse
💚 #40232 [Testing needed] Gun volume audit for 5.45 and 4.6, by LaVeyanFiend
💚 #40230 new zombie: necro-boomer, by KorGgenT
💚 #40228 Using antiseptic from a bottle in the inventory wastes the leftovers/returns them to the inventory incorrectly, by mrkybe
💚 #40224 Magiclysm Finger Firelighter cannot light gasoline lanterns, by dsmky117
💚 #40223 Scroll through npc options and scroll through barthering items like on multidrop., by rafaelkb
💚 #40218 items dropped by npcs before recruited still considered stealing if picked up, by Killa3999
💚 #40213 [Testing needed] Gun volume audit for .44 Magnum, by LaVeyanFiend
💚 #40210 give protein bar it's own wrapper, by Jerimee
💚 #40205 Standardize unicode characters, by ymber
💚 #40204 [magiclysm] Repeat castings of Aura of protection results in 'no hands free', by Resok
💚 #40203 Vehicle Welding Rig... Not enough charge, by fallout2077
💚 #40202 Items duplicate if unloaded from dropped container while arms broken, by Lum4r
💚 #40201 Picking up some items results in one no longer being displayed in inventory?, by Resok
💚 #40199 mini reactors, by kingcet
💚 #40197 Comestible containers only spawn with single charge, by Maleclypse
💚 #40196 Advanced Inventory displays wrong information, by CMDaddyPig
💚 #40195 Pudding crash bug report, by piatsa
💚 #40193 Item insulation does not work, by Hirmuolio
💚 #40192 Attempting to consume certain items related to CBMs from containers causes the game to crash., by Monochromatica
💚 #40190 UPS in Aftershock doesn't work, by RedShakespeare
💚 #40188 Gasoline powered tools cannot be reloaded (You don't have any gasoline to reload your [tool]), by angstr0m
💚 #40187 Unable to charge electric jackhammer (UPS) with recharging station., by Monochromatica
💚 #40186 Item length, by KorGgenT
💚 #40184 An option to rearrange martial arts menu and reassign keys, by Nvemri
💚 #40183 Unable to refuel Battery System CBM., by Monochromatica
💚 #40179 Can no longer unload or reload canteens/flasks/containers with liquid contents, by Resok
💚 #40177 Finish making consume take time, by Ramza13
💚 #40175 Trading with NPCs does not update the Volume/Weight indicator for contained items, by Resok
💚 #40173 WIP [Aftershock] Bugfixes for Uplifted Enforcer and uplifts, by Maleclypse
💚 #40170 List current mod/step when displaying error when starting/loading game, by sdp0et
💚 #40169 Favored pockets, by dissociativity
💚 #40164 Improve obtain_cost algorithm for pockets, by KorGgenT
💚 #40163 Implement "rummage through container" activity, by KorGgenT
💚 #40158 Unloading sewing kit creates a "none" item, by olanti-p
💚 #40157 Armor/tools parts display [do you like this feature?], by matt32106
💚 #40154 (Nested Containers) Dropping items crash: MinGW runtime Assertion - Assertion Failed, by DillonSimeone
💚 #40148 Game systems don't deplete battery when the "Play anything for a while" option is used., by Moxanity
💚 #40146 Ammo pouch don`t accept pebble or marbles (bullet crossbow ammo), by Katanasoul91
💚 #40144 Move more body_part to bodypart_id in Character part1, by Fris0uman
💚 #40137 Cattle fodder & containers, by ScampsAdams
💚 #40135 Sell low and sell high, Hub 01 Gold Coin, by oyydd
💚 #40134 Advanced inventory creates item called none, by Kouwed
💚 #40132 Lang files' loading doesn't work on Android, by RedShakespeare
💚 #40130 Plastic bottles can be put in gallon jugs, by RedShakespeare
💚 #40129 Segmentation fault when attempting to wield item stored in wielded container, by aoae23
💚 #40128 Bleach and ammonia are spawning with incorrect units by default, by aoae23
💚 #40127 Canned items are spawning opened again, by aoae23
💚 #40125 Cannot reload the sewing kit with thread. Thread is gone, no reloading. , by romanpogosov-usa
💚 #40120 I can't change the keyboard I'm using on this game, by leviboom09
💚 #40119 Liquid issues with #39406, by RedShakespeare
💚 #40118 Reloading bugs, by mrkybe
💚 #40115 Item disappears when you try to insert it into a partially-filled container, by FuelType-Memes
💚 #40109 Wrong items are moved in advanced inventory screen, by Inglonias
💚 #40104 Hauling while sorting is counter productive., by RogueYun
💚 #40089 NPCs to use ranged weapons against all enemies, and automatic fire against dangerous enemies, by zachmmeyer
💚 #40088 [Magiclysm] Thermal dissipation CBM and internal climate control doesn't prevent demon spider fire damage, by KingApep

CLOSED ISSUES

LIKED ISSUE

👍 #40186 Item length, by KorGgenT
It received 👍 x14, 😄 x0, 🎉 x8 and ❤️ x1.

NOISY ISSUE

🔈 #40203 Vehicle Welding Rig... Not enough charge, by fallout2077
It received 12 comments.

PULL REQUESTS

Last week, 225 pull requests were created, updated or merged.

OPEN PULL REQUEST

Last week, 4 pull requests were opened.
💚 #40396 Clarify 'make install PREFIX' for Linux., by rickumali
💚 #40390 Disallow dup json comments, by jbytheway
💚 #40387 Reduce calorie message spam to once every 12 hours, by CodeBandit
💚 #40384 Migrate message log UI and NPC trade UI to ui_adaptor, by Qrox

UPDATED PULL REQUEST

Last week, 51 pull requests were updated.
💛 #40391 mall cleanup part 3, by curstwist
💛 #40388 Add a coverage value to the firefighter belt, by matt32106
💛 #40382 [CR] Bugfix/cannot reload charged items, by mft-dev
💛 #40371 Convert islot_seed to generic_factory, by anothersimulacrum
💛 #40362 Add a PoolWater to Connects_to and update JSON_INFO, by sah4001
💛 #40361 Create crafting recipes for roller blades and skates, by LyleSY
💛 #40360 Implement requirement for manual install of CBMs, by Fris0uman
💛 #40353 Addtional NPC Dialogue - Patch 2, by TheCaledonian
💛 #40351 rework herbivore mutation chain, by enaantd
💛 #40349 [WIP] Allow remote unfolding of folded carts and the likes, by Pupsi-Mupsi
💛 #40342 Animate tiles marked as animated in tile_config.json, by verate
💛 #40328 Add test spells (json) and spell tests (cpp), by wapcaplet
💛 #40321 Restore variable encumbrance, by jbytheway
💛 #40320 improve containers.json, by Jerimee
💛 #40299 Define pockets for all integral magazines, by ymber
💛 #40284 Gorging penalties, by Ramza13
💛 #40274 standardize zines (books, not ammo), by Jerimee
💛 #40271 adjust insert menu to support multiple items, by KorGgenT
💛 #40270 [WIP] Refactor player hardcoded effects and include tests, by wapcaplet
💛 #40263 Gun volume audit for 7.62x39 x54, by LaVeyanFiend
💛 #40258 Content - Toiletry Bag, by LambdaSix
💛 #40250 "Zombie kill station" map extra, by Night-Pryanik
💛 #40242 bugfix_line_spell: prevent narrow line spells from being stopped early, by OrenAudeles
💛 #40235 WIP Refridgerated Tank Fix, by Maleclypse
💛 #40232 [Testing needed] Gun volume audit for 5.45 and 4.6, by LaVeyanFiend
💛 #40213 [Testing needed] Gun volume audit for .44 Magnum, by LaVeyanFiend
💛 #40210 give protein bar it's own wrapper, by Jerimee
💛 #40186 Item length, by KorGgenT
💛 #40177 Finish making consume take time, by Ramza13
💛 #40173 WIP [Aftershock] Bugfixes for Uplifted Enforcer and uplifts, by Maleclypse
💛 #40144 Move more body_part to bodypart_id in Character part1, by Fris0uman
💛 #40089 NPCs to use ranged weapons against all enemies, and automatic fire against dangerous enemies, by zachmmeyer
💛 #40081 Adds recipes for bike and motorbike alternators., by Tamiore
💛 #40037 WIP [Aftershock] Afs Scraps and the places they spawn, by Maleclypse
💛 #40011 Add recipe to make technomancer's toolbelt, add gold infuser and corresponding recipe, edited copper and silver infuser and their recipe, by martinrhan
💛 #39973 Make purifying water take a reasonable amount of time, by SkuliAdams
💛 #39964 Rework kevlar, add slash resistant and EOD gear, by ymber
💛 #39961 [WIP] Adds recipe to modify normal batteries to be used in vehicles., by Tamiore
💛 #39793 Overhaul look around panels, by ymber
💛 #39556 Remove RM99 caseless revolver, by tenmillimaster
💛 #39485 Spaces Removal, by klorpa
💛 #39387 Prevent gaining non-intelligence stats from reading with Stats Through Skills, by anothersimulacrum
💛 #38654 Airgun nerf & air cylinders, by misterprimus
💛 #38247 SIG SG magazines and rifles, by SnowFreeTrack
💛 #38155 Delivery Packages (part 1), by cosmiccoincidence
💛 #37994 PASGT and better helmets, by TheGamingFox1911
💛 #37908 WIP [Aftershock] Frankenstein NPCs, by Maleclypse
💛 #37343 Add inactive robot disassembly recipe, by Dziugaske
💛 #37105 New Elf-A Mutations, by zoshkalin
💛 #37103 Magical plants and where to find them, by John-Candlebury
💛 #36645 Tweaked zombie soldier, cop and survivor drop lists, by Night-Pryanik

MERGED PULL REQUEST

COMMITS

Last week there were 298 commits.
🛠️ [Fix for player being unable to use most vehicle mounted tools in crafting (#40383) * Fix for PSEUDO item not being generated with magazines for inventory::form_from_map().

Minor cleanup for veh_battery variable for clarity.](7f3d163) by Resok
🛠️ Update mod test blacklist for removed mods (#40338) by anothersimulacrum
🛠️ Added bell pepper (#39547) by TheSalamanderDJ
🛠️ Merge pull request #40358 from jbytheway/generalize_reduce_tests Generalize reduce_tests tool by ZhilkinSerg
🛠️ [Add "TARGET" category to some keybindings (Add "TARGET" category to some keybindings #40348) * Add missing category to target UI keybindings
Move them to single spot
Change 'F' from FIRE to SWITCH_MODE
To be consistent with how it works outside target selection UI](442916a) by olanti-p
🛠️ Fix pocket obtain shenanigans (#40322) by nphyx
🛠️ Hats for Retrodays+ (#40367) by Wokko1
🛠️ Merge pull request #40381 from BevapDin/bbm Reset loaded monster adjustments. by ZhilkinSerg
🛠️ Reset loaded monster adjustments. by BevapDin
🛠️ [Add resizing callbacks to uilist (Add resizing callbacks to uilist #40346) * Add desc_lines_setup for repeatable setup of uilist
Remove unused MENU_WIDTH_ENTRIES
Add setup callbacks of uilist dimensional parameters for repeatable setup
Use setup callbacks in color.cpp
Use setup callbacks in editmap.cpp
Use setup callbacks in game.cpp
Use setup callbacks in magic.cpp
Use setup callbacks in string_input_popup.cpp
Use setup callbacks in wish.cpp
Fix skill editor menu closing when selecting skill to modify](4aa0d6d) by Qrox
🛠️ Remove orphaned code from obsolete mods (#40357) by anothersimulacrum
🛠️ 2 ex for min item vol (#40366) by Jerimee
🛠️ Subtract 1 from the drop counter (#40372) by mrkybe
🛠️ Merge pull request #40378 from Fris0uman/foodpockets Give Foodperson approriate snacks™ to carry by ZhilkinSerg
🛠️ Merge pull request #40380 from BrettDong/i18n Routine i18n updates on 9 May 2020 by ZhilkinSerg
🛠️ [Fix crash at startup. (Fix crash at startup. #40377) * Don't store the result of options_manager::get_lang_options

Instead of storing it in a public variable, just make the code that uses it (two places only) call the function directly.

This also gets rid of the initialization order bug (where the language path was set after the options had been loaded).

Remove unnecessary class reference in type names.](d7abbf9) by BevapDin
🛠️ Merge pull request #40375 from Qrox/fix-overmap-blink Fix overmap UI blinking on curses build by ZhilkinSerg
🛠️ Routine i18n updates on 9 May 2020 by BrettDong
🛠️ Give Foodperson more approriate snacks to carry by Fris0uman
🛠️ Remove several obsolete mods (#40332) by anothersimulacrum
🛠️ Merge pull request #40350 from CodeBandit/Estoc Add estoc to fencing weapons by Rivet-the-Zombie
🛠️ Fix overmap UI blinking on curses build by Qrox
🛠️ Add Estoc fake and inferior to fencing by CodeBandit
🛠️ Remove dead mods: Tankmod by anothersimulacrum
🛠️ Remove dead mods: Salvaged Robots by anothersimulacrum
🛠️ Merge pull request #40236 from Kilvoctu/compact-aim-window-pt2b Compact aim window pt.2 - Numbers by ifreund
🛠️ Merge pull request #40359 from jbytheway/remove_expensive_test Remove walk 1000 miles test by ralreegorganon
🛠️ Remove walk 1000 miles test This test is rather slow, and doesn't test anything that isn't fairly well-tested by other tests. Delete it to save time. by jbytheway
🛠️ Generalize reduce_tests tool Previously it worked only with one test executable, but when building with CMake you might have a different one. Use whichever is the most recently modified. by jbytheway
🛠️ Merge pull request #40304 from anothersimulacrum/waterloo Replace hardcoded water terrain checks with flags by ZhilkinSerg
🛠️ Merge pull request #40355 from anothersimulacrum/modname Remove AFS pointless plut_cell & battery overrides by ZhilkinSerg
🛠️ Remove AFS pointless plut_cell & battery overrides by anothersimulacrum
🛠️ Replace hardcoded water terrain checks with flags This should expand coverage and make sure that all shallow and deep water types are appropriately used. by anothersimulacrum
🛠️ Merge pull request #40345 from CleverRaven/kevingranade-initabool Init a bool by ZhilkinSerg
🛠️ Add estoc to fencing weapons by CodeBandit
🛠️ supplydrop bulk crate (#40216) by Jerimee
🛠️ CRIT Expansion Update (#33556) by Soupster89
🛠️ Merge pull request #40344 from RoyBerube/engorge-on-infinite Fixes issue #40225 by ZhilkinSerg
🛠️ Merge pull request #40296 from BevapDin/wlf Fix map_cursor containing local coordinates by ZhilkinSerg
🛠️ Remove dead mods: More classes scenarios by anothersimulacrum
🛠️ Remove dead mods: Map specials demo by anothersimulacrum
🛠️ Remove dead mods: Tolerate This by anothersimulacrum
🛠️ [More itype refactoring - islot_book, islot_armor, islot_pet_armor (More itype refactoring - islot_book, islot_armor, islot_pet_armor #40226) * refactor islot_armor to use deserialize
refactor islot_pet_armor to use deserialize
refactor islot_book to use deserialize](f98c3d2) by KorGgenT
🛠️ [Fix helicopter rotor collides at twice the rotor diameter (Fix helicopter rotor collides at twice the rotor diameter #40313) * Use radius, not diameter
Update src/vehicle_move.cpp

Co-authored-by: ZhilkinSerg ZhilkinSerg@users.noreply.github.com

Co-authored-by: Kevin Granade kevin.granade@gmail.com
Co-authored-by: ZhilkinSerg ZhilkinSerg@users.noreply.github.com](b3c9415) by olanti-p
🛠️ Eat crash hotfix by KorGgenT
🛠️ Audit pine nuts and remove the recipe (#40305) * Obsolete pine nut recipe and enhance pine nut spawns by CodeBandit
🛠️ Allow changing Z-level if there is a creature in the way, but we have a spot to displace it into by olanti-p
🛠️ Block bound inventory keys from auto assignment (#40288) by eJ0opb
🛠️ Remove dead mods: Modular turrets by anothersimulacrum
🛠️ Remove dead mods: More Survival Tools & Hydroponics by anothersimulacrum
🛠️ Remove dead mods: Heavy Mining and Classes/Shields by anothersimulacrum
🛠️ Merge pull request #40326 from anothersimulacrum/rm-mod0 Remove dead mods: Fictional weapons and grow pots by kevingranade
🛠️ Remove dead mods: Craft gun, EW pack, fold parts by anothersimulacrum
🛠️ [When aiming, draw approximate lines of fire for each turret in range (#40198) * Draw approximate lines of fire for each turret in range

Make it work on TILES
Make it optional
Enable it by default if aiming a single turret](eaae5ea) by kevingranade
🛠️ Init a bool by kevingranade
🛠️ Move bionic_data to generic_factory (#40155) by Fris0uman
🛠️ Move more body_part to bodypart_id (#40138) by Fris0uman
🛠️ Update consumption.cpp Attempt to engorge on infinite source properly triggers consequence check. by RoyBerube
🛠️ Merge pull request #40253 from RedShakespeare/music_instrument Add previously missing json-loading of desc_freq in music instruments by Rivet-the-Zombie
🛠️ cleanup remove leftover comment and center colors legend for english by Kilvoctu
🛠️ Remove dead mods: Fictional Weapons, Growable Pots by anothersimulacrum
🛠️ Make compose.py's exit code 1 if error logged This is a bit of a hack, but usage of a global seems to be the minimally invasive way to do this. Also categorized the messages into Info, Warning, and Error types. by ifreund
🛠️ Update pocket_data documentation (#40324) by Jerimee
🛠️ Merge pull request #40316 from curstwist/tea add new tea item_groups by ZhilkinSerg
🛠️ Merge pull request #40314 from wapcaplet/pocket-info Fix iteminfo tests and refactor pocket display by ZhilkinSerg
🛠️ add new tea item_groups by curstwist
🛠️ Use iteminfo_parts flags for pocket info In the item info display, pocket "general_info" display is now shown only if the new iteminfo_parts::DESCRIPTION_POCKETS flag is given, and contents info is only added if DESCRIPTION_CONTENTS is given. These changes allow 3 of the formerly failing iteminfo_test assertions to pass. The other 2 formerly failing tests related to BASE_RIGIDITY, which is handled at the pocket level now), so the "item rigidity" tests were simply removed. by wapcaplet
🛠️ Merge pull request #40280 from xanderrootslayer/knife_churl Churls have proper medieval daggers by ZhilkinSerg
🛠️ Remove obsolete zombie grenadier (#40298) by anothersimulacrum
🛠️ Merge pull request #40292 from jbytheway/debug_disables_achievements Using the debug menu disables achievements by ZhilkinSerg
🛠️ Merge pull request #40300 from anothersimulacrum/skill_obs Remove old skill boost migration code by ZhilkinSerg
🛠️ Remove obsolete no_x mods (#40301) by anothersimulacrum
🛠️ Add check_needs_extremes msgs for npcs (#40294) by RedShakespeare
🛠️ [fix typo in containers documentation (fix typo in containers documentation #40309) * fix typo in containers documentation
Update doc/JSON_INFO.md

Co-authored-by: ZhilkinSerg ZhilkinSerg@users.noreply.github.com

Co-authored-by: Curtis Merrill curtis.r.merrill@gmail.com
Co-authored-by: ZhilkinSerg ZhilkinSerg@users.noreply.github.com](75b80bc) by enaantd
🛠️ Merge pull request #40291 from jbytheway/enforce_localized_sorting_3 Enforce localized sorting 3 by ZhilkinSerg
🛠️ Merge pull request #40302 from ifreund/thif-to-theif Fix typo causing thief mode bug by ZhilkinSerg
🛠️ Fix typo causing thief mode bug Fixes https://github.com/CleverRaven/Cataclysm-DDA/issues/40231 by ifreund
🛠️ Remove old skill boost migration code by anothersimulacrum
🛠️ Fix map_cursor containing local coordinates map_cursor is used in item_location, which in turn is used by the player_activity, which in turn is used by NPCs. So if you ask an NPC to butcher something, it will move to the corpse and "wait" there (won't move until the butchering is done). This stores are references to the corpse via an item_location (and the contained map_cursor), which means it stores the local coordinates of the corpse. If you move far enough away, so the map shifts, those coordinates are now pointing to a different location. Consequently, when the butchering finishes, it will try to remove the corpse from the wrong place. I fixed this with the smallest amount of code changes possible. But it's not a good fix. Better would be to access the tripoint via dedicated getters. This may also fix some other bugs that display a "Tried to remove item from object which did not contain it" message. by BevapDin
🛠️ Fix crash caused by accessing item of empty list. The function are_requirements_nearby accesses player::backlog::front(), which causes UB when the backlog list is empty. This is usually checked by the caller, but there is at least one way to reach this function without that check: #2 0x000000000083dfaa in string_id<activity_type>::operator== (rhs=..., this=0xdf1b460) at src/player_activity.h:93 #3 are_requirements_nearby (loot_spots=std::vector of length 21, capacity 32 = {...}, needed_things=..., p=..., activity_to_restore=..., in_loot_zones=true, src_loc=...) at src/activity_item_handling.cpp:1113 #4 0x0000000000843a46 in generic_multi_activity_check_requirement (p=..., act_id=..., act_info=..., src=..., src_loc=..., src_set=std::unordered_set with 1 element = {...}, check_only=false) at src/activity_item_handling.cpp:2676 #5 0x0000000000852813 in generic_multi_activity_handler (act=..., p=..., check_only=check_only@entry=false) at src/activity_item_handling.cpp:2885 #6 0x0000000000800896 in activity_handlers::multiple_butcher_do_turn (act=<optimized out>, p=<optimized out>) at src/activity_handlers.cpp:3822 #7 0x000000000082b248 in std::_Function_handler<void (player_activity*, player*), void (*)(player_activity*, player*)>::_M_invoke(std::_Any_data const&, player_activity*&&, player*&&) (__functor=..., __args#0=<optimized out>, __args#1=<optimized out>) at /usr/include/c++/8/bits/std_function.h:88 #8 0x00000000008630e3 in std::function<void (player_activity*, player*)>::operator()(player_activity*, player*) const (this=<optimized out>, __args#0=<optimized out>, __args#0@entry=0xdf1b330, __args#1=<optimized out>, __args#1@entry=0xdf1ae50) at /usr/include/c++/8/bits/std_function.h:260 #9 0x0000000000860306 in activity_type::call_do_turn (this=0x2c3c930, act=act@entry=0xdf1b330, p=p@entry=0xdf1ae50) at src/activity_type.cpp:118 #10 0x00000000014a968b in player_activity::do_turn (this=this@entry=0xdf1b330, p=...) at src/player_activity.cpp:237 #11 0x00000000013092a4 in npc::do_player_activity (this=this@entry=0xdf1ae50) at src/npcmove.cpp:3299 #12 0x0000000001322a07 in npc::execute_action (this=this@entry=0xdf1ae50, action=<optimized out>, action@entry=npc_player_activity) at src/npcmove.cpp:1237 #13 0x000000000132690a in npc::move (this=this@entry=0xdf1ae50) at src/npcmove.cpp:907 This adds a simple check within the function. by BevapDin
🛠️ Using the debug menu disables achievements We don't want people to accidentally get achievements when they are merely doing dev work or debugging issues. Make it so that most debug menu functions disable achievements. Also, add a new debug menu option to re-enable them (for cases where people were just working around bugs, or when people want to debug achievements themselves). When achievements are disabled, the tracker still tracks them but doesn't print any log messages when they are attained. Longer-term, this will matter more. Once there is global tracking of achievements across games the achievements attained while they were disabled won't count towards that. by jbytheway
🛠️ [Reformat MAGIC.md for improved readability (#40277) * Reformat MAGIC.md tables and JSON examples

Fix typo in effect_str example

Co-authored-by: Matthew S. Klosak msklosak@gmail.com](0466c67) by wapcaplet
🛠️ Lots more books (#37377) by Jerimee
🛠️ Enable it by default if aiming a single turret by olanti-p
🛠️ Make it optional by olanti-p
🛠️ Make it work on TILES by olanti-p
🛠️ Draw approximate lines of fire for each turret in range by olanti-p
🛠️ Merge pull request #40285 from KorGgenT/fix-consume-menu-again allow consume menu to look in containers by ZhilkinSerg
🛠️ Merge pull request #40286 from KorGgenT/adjust-default-best-pocket adjust better pocket formula to prefer non watertight containers by ZhilkinSerg
🛠️ [Flu vaccine lasts 6 months instead of forever (#40287) * Make flu shot last 6 months instead of forever

Co-authored-by: Curtis Merrill curtis.r.merrill@gmail.com

DoT class
Save and load DoT
doc
Apply suggestions from code review

Co-authored-by: Curtis Merrill curtis.r.merrill@gmail.com

serialize, deserialize and load in proper cdda fashion

Co-authored-by: Curtis Merrill curtis.r.merrill@gmail.com](11714a3) by Fris0uman
🛠️ [DinoMod] Create recipe_food.json Now you're cooking with dino eggs by LyleSY
🛠️ Audit 1874 Sharps Rifle by LaVeyanFiend
🛠️ Audit Magnum Research BFR by LaVeyanFiend
🛠️ Audit Marlin 1895 SBL by LaVeyanFiend
🛠️ Convert some std::sort calls to localized_compare These are the ones that were caught by the recently improved check. by jbytheway
🛠️ Suppress warning on sorting directory names by jbytheway
🛠️ Remove unnecessary '/' character by jbytheway
🛠️ Sort achievements by name, not description by jbytheway
🛠️ Expand sorting check to std::sort calls Look for calls which sort strings in a non-localized manner. by jbytheway
🛠️ Merge pull request #40131 from akirashirosawa/fix-macos-memory-leak HotFix macOS memory leak by ZhilkinSerg
🛠️ Merge pull request #40094 from Qrox/migrate-ui-12 Migrate inventory_ui.cpp and game_inventory.cpp to ui_adaptor by ZhilkinSerg
🛠️ Make point and tripoint abs functions into methods. (#40106) by kevingranade
🛠️ CFRelease CFString objects Core Foundation functions have names that indicate when you own a returned object:
Object-creation functions that have "Create" embedded in the name;
Object-duplication functions that have "Copy" embedded in the name.
If you own an object, it is your responsibility to relinquish ownership (using CFRelease) when you have finished with it. by akirashirosawa
🛠️ Merge pull request #40123 from kevingranade/fix-iteminfo-crafting-test Fix crafting iteminfo test by ZhilkinSerg
🛠️ Consume menu fix (#40108) by KorGgenT
🛠️ Update materials for bullet damage type (#40112) by anothersimulacrum
🛠️ map fixes (#40113) by curstwist
🛠️ Migrate inventory_ui.cpp and game_inventory.cpp to ui_adaptor by Qrox
🛠️ Merge pull request #40049 from Rail-Runner/plants3 Add spurge seeds by Rivet-the-Zombie
🛠️ Change player_activity::start to player_activity::start_or_resume and remove unnecessary include by rsulli55
🛠️ storage definition hotfix by kevingranade
🛠️ Migrate ACT_DIG to the activity_actor system Per issue #40013 all activities should be migrated to the activity_actor system references #40013 by rsulli55
🛠️ Fix crafting iteminfo test by kevingranade
🛠️ Merge pull request #40105 from ZhilkinSerg/overmap-terrain-id-declutter-2020-05-05 Declutter overmap terrain definitions (2020-05-05) by kevingranade
🛠️ Merge branch 'master' of https://github.com/CleverRaven/Cataclysm-DDA into migrate-dig-activities by rsulli55
🛠️ Added a bool resuming to player_activity::start so that when an activity_actor is resumed, its start member function is not called. Without this, the dig_channel_activity_actor and open_gate_activity_actor reset moves_total of the activity when they are resumed by rsulli55
🛠️ Replace random lab turrets with lab security There's not really any rationale for placing turrets in random locations that aren't of high value in labs. It makes much more sense to have lab security there, as opposed to turrets. by anothersimulacrum
🛠️ Remove duplicated damage entry in Aftershock file. by John-Candlebury
🛠️ Allow HEALING_RATE for any effect (#40072) by Fris0uman
🛠️ Max stamina modifiers from mutations now affect stamina regen (#39994) by CodeBandit
🛠️ [Bionic fingerpick fix (#39857) * Added new PICKABLE flag to all pickable terrains and locked gun safe furniture
Also added documentation.

Reworked bionic lockpicks activation
Now it temporarily creates a copy of a fake bionic lockpicks item in player inventory, activates activity with this item, and immediately after that removes this item from inventory.
100% chance to pick lock with bionic picklocks
Replaced hardcoded terrain/furniture list with a check for PICKABLE flag
Special case for lockpicking activity: remove fake bionic lockpick item from player's inventory if activity is canceled mid-way](17b6b76) by Night-Pryanik
🛠️ Alter the damage type/power draw of Modular turret mod laser weaponry by John-Candlebury
🛠️ Alter the damage type if CRIT laser weaponry by John-Candlebury
🛠️ Alter the damage type/power draw of Aftershock's laser weaponry by John-Candlebury
🛠️ Alter the damage type/power draw of mainline laser weaponry by John-Candlebury
🛠️ Add newly required tools to crafting test by kevingranade
🛠️ Update tea box to be a container by anothersimulacrum
🛠️ Prevent copying in range-based loops by anothersimulacrum
🛠️ Merge pull request #38912 from anothersimulacrum/dt_bullet by kevingranade
🛠️ [Magic bionics (Magic bionics #39940) * allow bionics to have you learn spells

created a couple new functions in spell to facilitate setting spell levels
spells you learn from a CBM make you gain the class trait
added documentation for usage

add bionic sneeze beam CBM

adjusted scroll drop to be CBM drop instead, and removed scroll from the drop list. additionally renamed the scroll for easier search in debug wish.](9936ba5) by KorGgenT
🛠️ Split some traits from professions (#40075) * Split some traits from professions by Rail-Runner
🛠️ [Mi-go, necromancers, and masters can open doors (#40065) * Zombie scientists can't open doors

Mi-go can open doors
Zombie masters and necros can open doors](fbf3b84) by kevingranade
🛠️ Add extra forging recipes, part 2 (#40057) by Rail-Runner
🛠️ Slipping when climbing down may happen only on unstable terrain below (#40035) by Night-Pryanik
🛠️ Xl underwear and accessories Part 1 (#39978) by Maleclypse
🛠️ Update throwing knives weight and size (#39992) by CodeBandit
🛠️ Merge pull request #39939 from crazykid080/ninjutsu-survival-machete Add survival machete to ninjutsu weapons by kevingranade
🛠️ [Aftershock] Uplifted monsters and zombies (#39097) by Maleclypse
🛠️ Merge pull request #39928 from Night-Pryanik/improvised-lockpicks-recipe-tweak Improvised lockpicks recipe tweak by kevingranade
🛠️ Add tea bags, herbal tea bags and adjust drinks recipes (#39989) by CountAlex
🛠️ Scan for languages (#40056) by akirashirosawa
🛠️ [Long pole changes. (Long pole changes. #39924) * Rework long pole
Remove sheath spear from pikes and pole and durable melee from long pole](9b4d189) by kevingranade
🛠️ Final Blazemod PR: Finalise succession of modern Blaze Industries from blazemod (#40093) by Soup-de-Loop
🛠️ Update JSON_INHERITANCE.md (#40107) by Jerimee
🛠️ Merge pull request #40095 from Qrox/migrate-ui-13 Migrate overmap_ui.cpp to ui_adaptor by ZhilkinSerg
🛠️ Fix localized_comparator for macOS (#40100) by akirashirosawa
🛠️ Declutter necropolis terrains by ZhilkinSerg
🛠️ Merge branch 'master' into dt_bullet by kevingranade
🛠️ Merge pull request #40102 from curstwist/mall-cleanup-part-2 mall cleanup part 2 by ifreund
🛠️ Extracts and Concentrates pt 6 (recipes) (#37959) all the crafting recipes and deconstruction recipe for the vac oven by NastyNate2612
🛠️ Merge pull request #40103 from olanti-p/fix-targets-behind-fences Fix aiming UI's aim-and-fire interrupting for some creatures by ifreund
🛠️ Merge branch 'master' of https://github.com/CleverRaven/Cataclysm-DDA into migrate-dig-activities by rsulli55
🛠️ Add a pure virtual can_resume_with function to activity_actor class to be used in player_activity::can_resume_with Add operator== to dig_channel_activity_actor to be used in its implementation of can_resume_with According to a TODO in player_activity::can_resume_with, a pure virtual can_resume_with should be transitioned to for activity_actor's references #40013 by rsulli55
🛠️ Declutter industrial terrains by ZhilkinSerg
🛠️ [[Magiclysm] Allow spells to spawn items with their containers (Allow spells to spawn items with their containers #40097) * Allow spells to spawn items with their containers

Add a "WITH_CONTAINER" flag for spells to spawn items with containers.

Update flags.json

CONTRIBUTORS

Last week there were 51 contributors.
👤 Resok
👤 anothersimulacrum
👤 TheSalamanderDJ
👤 ZhilkinSerg
👤 olanti-p
👤 nphyx
👤 Wokko1
👤 BevapDin
👤 Qrox
👤 Jerimee
👤 mrkybe
👤 BrettDong
👤 Fris0uman
👤 Rivet-the-Zombie
👤 CodeBandit
👤 ifreund
👤 ralreegorganon
👤 jbytheway
👤 Soupster89
👤 KorGgenT
👤 eJ0opb
👤 kevingranade
👤 RoyBerube
👤 Kilvoctu
👤 curstwist
👤 wapcaplet
👤 RedShakespeare
👤 enaantd
👤 rsulli55
👤 xanderrootslayer
👤 ymber
👤 LaVeyanFiend
👤 LyleSY
👤 Ramza13
👤 rchliu
👤 Dansiman
👤 procrustesmethod
👤 Aloxaf
👤 RipleyTom
👤 Pupsi-Mupsi
👤 int-ua
👤 Maleclypse
👤 John-Candlebury
👤 akirashirosawa
👤 Night-Pryanik
👤 Rail-Runner
👤 CountAlex
👤 Soup-de-Loop
👤 NastyNate2612
👤 sanfordmadness
👤 Someoneman

STARGAZERS

Last week there were 38 stagazers.
⭐ sohlk
⭐ micwoj92
⭐ RPINerd
⭐ FooSoft
⭐ FilleFirn
⭐ woncomp
⭐ mssx86
⭐ mordie1001
⭐ tuta0030
⭐ Lupinos
⭐ flikr
⭐ ZiyuXiong
⭐ royteutsch
⭐ rafaelkb
⭐ Zenvalley
⭐ bruceCoelho
⭐ Nexela
⭐ TheCaledonian
⭐ Mallowdust
⭐ bkinnear
⭐ AMS21
⭐ Mozgoid
⭐ jessicalewinter
⭐ Yardanico
⭐ sxt19941012
⭐ Bibizon
⭐ Draven187
⭐ 744130077
⭐ mayribeiro
⭐ georgegtth
⭐ LincolnMantle
⭐ olfa-said-hub
⭐ Esaupoceros
⭐ s-ariga
⭐ knightXun
⭐ yilaocha
⭐ fatihwk
⭐ carlank
You all are the stars! 🌟

RELEASES

That's all for last week, please 👀 Watch and ⭐ Star the repository CleverRaven/Cataclysm-DDA to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

The text was updated successfully, but these errors were encountered:

weekly-digest bot added the weekly-digest label May 10, 2020

int-ua closed this as completed Jan 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weekly Digest (3 May, 2020 - 10 May, 2020) #40403

Weekly Digest (3 May, 2020 - 10 May, 2020) #40403

weekly-digest bot commented May 10, 2020

Weekly Digest (3 May, 2020 - 10 May, 2020) #40403

Weekly Digest (3 May, 2020 - 10 May, 2020) #40403

Comments

weekly-digest bot commented May 10, 2020

ISSUES

OPEN ISSUES

CLOSED ISSUES

LIKED ISSUE

NOISY ISSUE

PULL REQUESTS

OPEN PULL REQUEST

UPDATED PULL REQUEST

MERGED PULL REQUEST

COMMITS

CONTRIBUTORS

STARGAZERS

RELEASES