Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tie & Remove leash have the same keybinding #51290

Closed
Brambor opened this issue Sep 1, 2021 · 1 comment · Fixed by #51793
Closed

tie & Remove leash have the same keybinding #51290

Brambor opened this issue Sep 1, 2021 · 1 comment · Fixed by #51793
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Controls / Input Keyboard, mouse, keybindings, input UI, etc. Good First Issue This is a good first issue for a new contributor Monsters Monsters both friendly and unfriendly. Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA

Comments

@Brambor
Copy link
Contributor

Brambor commented Sep 1, 2021

Describe the bug

Wanna tie them, but I Remove leashes from them instead.
Also, push and lead by leash have the same keybinding.

Steps To Reproduce

Tie turkey, examine them.

Expected behavior

When I press [t] I will now what will happen. Also, every keybinding listed at most once.

Screenshots

image

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: c11072c [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    Bionic Professions [package_bionic_professions]
    ]

Additional context

No response

@actual-nh actual-nh added Controls / Input Keyboard, mouse, keybindings, input UI, etc. Monsters Monsters both friendly and unfriendly. Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA labels Sep 1, 2021
@anothersimulacrum anothersimulacrum added [C++] Changes (can be) made in C++. Previously named `Code` Good First Issue This is a good first issue for a new contributor labels Sep 11, 2021
@anothersimulacrum
Copy link
Member

The p argument here needs to be something else

if( z.has_effect( effect_leashed ) ) {
if( z.has_effect( effect_led_by_leash ) ) {
amenu.addentry( stop_lead, true, 'p', _( "Stop leading %s" ), pet_name );
} else {
amenu.addentry( lead, true, 'p', _( "Lead %s by the leash" ), pet_name );
}
}

and the t argument here

amenu.addentry( unleash, true, 't', _( "Remove leash from %s" ), pet_name );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Controls / Input Keyboard, mouse, keybindings, input UI, etc. Good First Issue This is a good first issue for a new contributor Monsters Monsters both friendly and unfriendly. Quality of Life QoL: degree to which players are comfortable, and able to enjoy CDDA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants