Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move halberd from Medieval Stuff mod #15018

Merged
merged 5 commits into from
Jan 28, 2016
Merged

Move halberd from Medieval Stuff mod #15018

merged 5 commits into from
Jan 28, 2016

Conversation

Rail-Runner
Copy link
Contributor

Move halberd and its' fake version from Medieval Stuff mod into the main game.

Other changes:

  1. Remove AXE quality from halberd.
  2. Add COOK 1 quality to halberd. One could use a spike on its' end to cook a piece of meat over a fire.
  3. Remove LUMBER action from halberd.
  4. Add NON_STUCK flag to halberd.
  5. Reduce spawn rate of halberd in some item groups.
  6. Add halberd and its' fake version to No Medieval Items mod's blacklist.
  7. Remove unused BASH flag from some items.

Move halberd and its' fake version from Medieval Stuff mod into the main
game.

Other changes:

1. Increaxe AXE quality of halberd from 1 to 2.
2. Add COOK 1 quality to halberd. One could use a spike on its' end to
cook a piece of meat.
3. Add IMPALE technique to halberd.
4. Add REACH3 flag to halberd and its' fake version.
5. Reduce spawn rate of halberd in some item groups.
6. Add halberd and its' fake version to No Medieval Items mod's
blacklist.
@Coolthulhu
Copy link
Contributor

Increaxe AXE quality of halberd from 1 to 2.

AXE is for wood chopping. Halberd would make a terrible wood chopping tool due to how thin and light it is. A kukri would be more useful for chopping wood than a halberd and kukri doesn't have any AXE quality.

Add IMPALE technique to halberd.

Nailing 2 zombies with one thrust of the halberd would require the whole axe blade part to go through the first one.

Add REACH3 flag to halberd and its' fake version.

REACH3 is for pikes, not spears. Halberd is much shorter than a pike.

@chaosvolt
Copy link
Contributor

Swiggith swooty.

Yeah, I picked wood-cutting of 1 for the halberd because I figured it would be inferious as a tool to the battleaxe, which already has 2 quality. Giving it a cooking quality wasn't something I'd thought of, though. Clever.

And yeah, Coolthulhu mentioned the oddness of giving it impale back when I first added the halberd. X3

@TheRafters
Copy link
Contributor

Typical Spear: http://bashapedia.pbworks.com/f/1294528734/greek_armour__spear_tip.jpg
Typical Halberd: http://www.coldsteel-uk.com/store/maa-swiss-halberd-89msw-full-1.jpg

The shape would pretty much preclude impaling, much like the cross bar on a boar spear. I know a hydraulic muscled large mutant with very strong could probably do it, but we don't have a way to conditionally impale, do we? The aforementioned mutant could probably impale a zombie with the wide side of a door also...so, yeah...

@kevingranade
Copy link
Member

kevingranade commented Jan 25, 2016 via email

@chaosvolt
Copy link
Contributor

Hmm. Might be acceptable, sure. I think it was NON_STUCK if I recall?

@Rivet-the-Zombie
Copy link
Member

@chaosvolt, you are correct.

@Coolthulhu
Copy link
Contributor

Non-stuck prevents also chopping kind of sticking, though. Like what axes and machetes get.

@chaosvolt
Copy link
Contributor

Hmm, true. Also, if I recall, I asked whether giving it both CHOP and SPEAR would have any interesting effects back when, and the answer was no. Not sure if there's some way to represent it being capable of both.

"description": "This is a dull, cheaply made replica of a polearm with an axe blade, a spike, and other fun things attached to a long stick.",
"price": 5000,
"material": ["wood", "aluminum"],
"flags": ["BASH", "REACH_ATTACK"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no "BASH" flag.
Flags like "CHOP" and "SLICE" don't change the damage type, they only affect sticking chance.
Flags "SPEAR" and "STAB" do change the cutting type to piercing one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this flag was present on a few more weapons. I removed them from there too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, I'm not sure where I got the "BASH" flag for replicas.

@Coolthulhu Coolthulhu self-assigned this Jan 26, 2016
@@ -40,6 +40,8 @@
"scythe_war",
"pike",
"glaive",
"halberd",
"halberd_fake"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing separator

@Coolthulhu Coolthulhu removed their assignment Jan 26, 2016
@kevingranade
Copy link
Member

For my idea for nicer handling of the halberd, see #15034

@chaosvolt
Copy link
Contributor

Maybe, but a way of choosing the desired attack type would be better. It would be odd to lose chopping in melee range.

@Coolthulhu Coolthulhu self-assigned this Jan 28, 2016
Coolthulhu added a commit that referenced this pull request Jan 28, 2016
Move halberd from Medieval Stuff mod
@Coolthulhu Coolthulhu merged commit a1e749c into CleverRaven:master Jan 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants