Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed check of option prerequisites #27735

Merged
merged 3 commits into from
Jan 24, 2019

Conversation

ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg commented Jan 20, 2019

Summary

SUMMARY: Bugfixes "Fixed check of option prerequisites"

Purpose of change

Followup of #27566.
Fixes #27746.
Also should finally fix Android builds.

Fixes debug messages which appear when moving in Graphics options menu.

Describe the solution

Refactored code which checks if option prerequisite is fulfilled (is not empty and set to certain value).

Additional context

image

@ZhilkinSerg ZhilkinSerg added SDL: Tiles / Sound Tiles visual interface and sounds. [C++] Changes (can be) made in C++. Previously named `Code` labels Jan 20, 2019
@ZhilkinSerg ZhilkinSerg added the <Bugfix> This is a fix for a bug (or closes open issue) label Jan 21, 2019
@kevingranade kevingranade merged commit be1b069 into CleverRaven:master Jan 24, 2019
@ZhilkinSerg ZhilkinSerg deleted the fix-renderer-options branch January 24, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cataclysm graphics option error. ERROR : src/options.cpp:547
2 participants