IWYU support (part 3): Improve Visual Studio compatibility #27785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running IWYU broke the compile on VS because of it's complicated handling of math.h constants. This provides a single header to access those constants, and we can use IWYU to force people to include it, so that devs on other platforms are less likely to write code that breaks on VS. Also, this should make it possible to run IWYU without breaking the VS build.
This needs to be added by hand because it's non-Windows only, and IWYU will add it in a place where Windows will choke on it.
Missed this before; highlighted by a VS compile error.
IWYU needs to know that this is our compatibility header in order to use the correct includes.
ZhilkinSerg
added
[C++]
jbytheway
added a commit
to jbytheway/Cataclysm-DDA
that referenced
this pull request
Jan 23, 2019
This was removed in CleverRaven#27785 from posix_time.h and should have been added back into posix_time.cpp, but wasn't. Has been breaking the Mingw CI.
ThinkInvis
pushed a commit
to ThinkInvis/Cataclysm-DDA
that referenced
this pull request
Jan 24, 2019
This was removed in CleverRaven#27785 from posix_time.h and should have been added back into posix_time.cpp, but wasn't. Has been breaking the Mingw CI.
ThinkInvis
pushed a commit
to ThinkInvis/Cataclysm-DDA
that referenced
this pull request
Jan 24, 2019
This was removed in CleverRaven#27785 from posix_time.h and should have been added back into posix_time.cpp, but wasn't. Has been breaking the Mingw CI.
ThinkInvis
pushed a commit
to ThinkInvis/Cataclysm-DDA
that referenced
this pull request
Jan 24, 2019
This was removed in CleverRaven#27785 from posix_time.h and should have been added back into posix_time.cpp, but wasn't. Has been breaking the Mingw CI.
ThinkInvis
pushed a commit
to ThinkInvis/Cataclysm-DDA
that referenced
this pull request
Jan 24, 2019
This was removed in CleverRaven#27785 from posix_time.h and should have been added back into posix_time.cpp, but wasn't. Has been breaking the Mingw CI.
ThinkInvis
pushed a commit
to ThinkInvis/Cataclysm-DDA
that referenced
this pull request
Jan 24, 2019
This was removed in CleverRaven#27785 from posix_time.h and should have been added back into posix_time.cpp, but wasn't. Has been breaking the Mingw CI.
ThinkInvis
pushed a commit
to ThinkInvis/Cataclysm-DDA
that referenced
this pull request
Jan 24, 2019
This was removed in CleverRaven#27785 from posix_time.h and should have been added back into posix_time.cpp, but wasn't. Has been breaking the Mingw CI.
ThinkInvis
pushed a commit
to ThinkInvis/Cataclysm-DDA
that referenced
this pull request
Jan 24, 2019
This was removed in CleverRaven#27785 from posix_time.h and should have been added back into posix_time.cpp, but wasn't. Has been breaking the Mingw CI.
ThinkInvis
pushed a commit
to ThinkInvis/Cataclysm-DDA
that referenced
this pull request
Jan 24, 2019
This was removed in CleverRaven#27785 from posix_time.h and should have been added back into posix_time.cpp, but wasn't. Has been breaking the Mingw CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Rationalize Visual Studio compatibility code"
Purpose of change
The attempt at running IWYU led to some issues on Visual Studio (see CI failures on #27713). Looking through the AppVeyor build log, this is an attempt to resolve those.
Describe the solution
posix_time.hand a newmath_defines.h.debug/deque).strings.hinclude in a place which will not be compiled by Visual Studio, so that IWYU will not add it amongst the general includes.