IWYU support (part 5): Yet more SDL fixes #27810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes IWYU decides to use "SDL.h" when we want <SDL.h>. Add mappings to point it in the right direction.
Mention the complexity of the SDL headers. Link to JSON style guide. Formatting.
ZhilkinSerg
added
SDL: Tiles / Sound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
The SDL headers continue to be the bane of IWYU support. But I think I finally have them working as desired now.
Describe the solution
Add a bunch of new symbol mappings for the symbols used from
SDL.handSDL_ttf.h, because these two need special handling.The problem without these changes is that IWYU forces
<SDL.h>to change to"SDL.h". Not sure why; probably a bug, but easier to work around this way than fix in IWYU.Also updated the docs a little bit.