Make dollchat items display their speech lines again #27958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlangsdorf
added
[C++]
mlangsdorf
approved these changes
Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
(A)ctivating talking dolls would consume battery charges and produce a sound, but never actually display their lovely chatter to the user.
I didn't find an issue for this bug, to trigger simply debug wish for either of the two talking dolls or a companion potato.
Describe the solution
Speech text was not being displayed due to sound code not describing noises at the players position.
Fixed by adding an explicit message for dollchat speech if player can hear the sound, same as done in #27551 for music and others.
Describe alternatives you've considered
Display the message as "The %s says %s" rather than "Your hear %s". But I dimly remember it used to be the latter, and happens to work well especially for the creepier one (imho).
Additional context
The lines as they display with this fix. I confirmed the actual speech text shows up properly localized (in German), the "You hear" part however will be lacking translation.