-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More lab background tiles will match floor #27962
Conversation
I think you may squash some commits or even all of them to one. |
Thanks for catching that, squashed down to 4. |
I'll give it another go after my work on the mall is finished. If you can provide screenshots, that is the most helpful as some tilesets have the issue, some do not depending on the tilesets' configuration. I do know what you mean about the armory and living quarters though. So you prefer that the Another idea is that I could probably keep the floor the same but make the lights have the correct background. |
@SomeDeadGuy these screenshots help a lot. I'll take a second pass at the labs and reference your original issue again with the next PR. Thanks! |
Summary
SUMMARY: Bugfixes "More lab background tiles will match floor"
Purpose of change
Alleviates issue with lab terrain not matching surrounding floor tiles as described in #27139
Describe the solution
Adjusted new terrains to have
t_thconc_floor
where possible (such as deconstructing or bashing)Added new terrains to all tilesets. Used same graphic ID
t_thconc_floor
used or usedt_concrete
whent_thconc_floor
did not have a separate graphic available.Added
t_thconc_floor
andt_strconc_floor
to any tilesets that did not already have them defined.Describe alternatives you've considered
I am not aware of any alternatives to this issue
Additional context
Some tilesets such as Chesthole have the wooden door background filled in which prevents you from setting a background other than
t_floor
. To fix this, the png files must be edited.Some of the mapgen in the labs appear to use
t_door_metal_c
. This appears to be hardcoded and not configurable via JSON files.A lot of tilesets still have missing or incorrect backgrounds for items. Much of this likely needs to be fixed for the individual tileset.