Separate point, tripoint into new point.h #31892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
It never made sense that point and tripoint were in enums.h. Give them their own header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
It never made sense that
pointandtripointwere inenums.h.Describe the solution
Give them their own header
point.h.Describe alternatives you've considered
I only added headers as need to compile. This would be cleaned up a lot by another IWYU run, but I don't want to do that on this PR.
There's a reasonable change more
#includes will be needed on other platforms, so be sure to give Travis a chance to discover that.Additional context
The first step in my project to add coordinate-system type safety to these types.