Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magiclysm: Spell encumbrance and minor spellcasting ui tweaks #31902

Merged
merged 7 commits into from
Jun 27, 2019

Conversation

KorGgenT
Copy link
Member

@KorGgenT KorGgenT commented Jun 27, 2019

Summary

SUMMARY: Mods "Add penalties to spellcasting while encumbered based on the spell"

Purpose of change

It was a little too powerful to be able to wear whatever you wannted and be able to cast all of your spells at full power.

Describe the solution

See these flags:

  • SOMATIC, // arm encumbrance affects fail % and casting time (slightly)
  • NO_HANDS, // hands do not affect spell energy cost
  • NO_LEGS, // legs do not affect casting time
  • CONCENTRATE, // focus affects spell fail %
    image
    image

As you can see, I added the spell class at the top, and enumerated some information about the spell: the flags shown above, plus whether the spell goes through walls (only if the spell can make use of it, i.e. range > 1)
I also fixed the bug that showed a healing message if you do 0 damage to yourself with a spell.

@KorGgenT KorGgenT added <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. Mods Issues related to mods or modding <Bugfix> This is a fix for a bug (or closes open issue) labels Jun 27, 2019
src/magic.cpp Outdated Show resolved Hide resolved
@ZhilkinSerg ZhilkinSerg self-assigned this Jun 27, 2019
@ZhilkinSerg ZhilkinSerg merged commit facb626 into CleverRaven:master Jun 27, 2019
@ZhilkinSerg ZhilkinSerg removed their assignment Jun 27, 2019
@KorGgenT KorGgenT deleted the spell-encumbrance branch June 27, 2019 12:29
@Temptdos
Copy link

This is probably not the right place for it, but just wanted to confirm:

As it stands now, wearing only scavenger gear with 20 arm encumbrance, Nature's Bow cannot be cast as it's too difficult and spells like magic missile and wooden shaft take a 40% reduction in DPS.

@KorGgenT
Copy link
Member Author

i'm probably going to let the balance shake out a little before i adjust it again. this is mostly a rough estimation of what i want with implementation, for now. as far as nature's bow not being able to be cast, try leveling it up to decrease its spell failure % or increasing your spellcraft skill or intelligence.

@Temptdos
Copy link

Sounds good! I'm currently at 16 intelligence (dump stat at character creation + mutations) but my Nature's Bow is admittedly only level 1. Also, can you only increase your spellcraft skill via character creation or is there another method you need to find in the game? It's only level 3 from character creation.

Otherwise is it planned for dexterity/perception to reduce the encumbrance penalty for casting in the future?

@KorGgenT
Copy link
Member Author

spellcraft increases by studying spells in spellbooks. capped at the spell's difficulty.

@Temptdos
Copy link

Awesome, and thanks for making this mod!

@DorfGuy1
Copy link

Love it, reminds me of DnD wherein wizards can't wear heavy armor because they need unristricted movement.

@KorGgenT KorGgenT added the Mods: Magiclysm Anything to do with the Magiclysm mod label Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) <Enhancement / Feature> New features, or enhancements on existing Info / User Interface Game - player communication, menus, etc. Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants