Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored vehicle emitters #31913

Merged

Conversation

ZhilkinSerg
Copy link
Contributor

Summary

SUMMARY: Infrastructure "Refactored vehicle emitters"

Purpose of change

Refactored vehicle emitters. Follow-up after #31888.

Describe the solution

  • use emit.json;
  • added consistency check;
  • renamed flag;
  • removed unused code.

- use `emit.json`;
- added consistency check;
- renamed flag;
- removed unused code.
@ZhilkinSerg ZhilkinSerg added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Jun 27, 2019
{
"id": "emit_cooler_vehicle",
"type": "emit",
"//": "Emission from vehicle cooler",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "cooler_vehicle" part from the id string is a dead giveaway that this has something to do with the vehicle cooler. But it's nice to see my suspicion being confirmed explicitly.

@kevingranade kevingranade merged commit 9c4f4cc into CleverRaven:master Jun 27, 2019
@ZhilkinSerg ZhilkinSerg deleted the refactor-vehicle-emitters branch June 28, 2019 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants