Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n case insensitive search #33206

Merged
merged 2 commits into from
Aug 14, 2019
Merged

I18n case insensitive search #33206

merged 2 commits into from
Aug 14, 2019

Conversation

akirashirosawa
Copy link
Contributor

Summary

SUMMARY: Bugfixes "Case insensitive search for non-latin characters"

Purpose of change

Fixes #21566 (and my duplicate #32999)
Finalizes PR #26983 (by @AMurkin)

Describe the solution

  1. Set global locale by the language settings, and update when language changed.
  2. Catch exception when locate is not available in system (for example es_AR is not available for my macOS), and in this case set en_US.
  3. If locale is not en_US - use facet of locale for locale-specific tolower.

With all recipes available (from debug menu) - I didn't notice changes in the search speed, even with full description search.

Russian example (KATANA aka КАТАНА)
ru

Polish example (GOLD aka ZŁOTO)
pl
)

English works as before, without changes and unnecessary string converts.
en

Describe alternatives you've considered

Additional context

@kevingranade kevingranade merged commit 278482c into CleverRaven:master Aug 14, 2019
@akirashirosawa akirashirosawa deleted the i18n-case-insensitive-search branch August 14, 2019 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using /-filter don't respect capitalization in localization
2 participants