Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Case insensitive search for non-latin characters"
Purpose of change
Fixes #21566 (and my duplicate #32999)
Finalizes PR #26983 (by @AMurkin)
Describe the solution
es_AR
is not available for my macOS), and in this case seten_US
.en_US
- use facet of locale for locale-specifictolower
.With all recipes available (from debug menu) - I didn't notice changes in the search speed, even with full description search.
Russian example (KATANA aka КАТАНА)
Polish example (GOLD aka ZŁOTO)
)
English works as before, without changes and unnecessary string converts.
Describe alternatives you've considered
Additional context