-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canning apple cider and other juices #36747
Canning apple cider and other juices #36747
Conversation
catchup to cleverraven
Catchup to CleverRaven
Also fixed some missing byproducts in basic juice recipes.
The calorie generation tests are either failing due to randomness or something I have no control over. The recipes are correct. |
Revert if this doesn't fix things
This reverts commit 0b9b189.
If this fails remove all specific juices.
@anothersimulacrum I've tried shrinking the component calories and that didn't make it work, I've doubled from the original calorie components and that at least reduced the number of failed tests. I'm at a loss here and I'm not sure if the calories listed in the apple cider, oj and cranberry juice json entries are calorie overrides and that's causing the issue? because they certainly don't match up with when you actually make the item ingame. |
Despite failed C/travis tests, everything creates fine. There are inexplicable calorie differences between various recipes, however they tend to be around 10 kcal's except the water/fruit fruit juice recipe comes in at double the calories of pure fruit juice. |
Move these from autolearn to a book on canning and I'll merge em |
@Maleclypse Oh shoot, I missed your earlier comment. I'll have a poke at these and see what I can do to get the tests passing later. |
I'll make this a separate book from the rest of the canning recipes, that I'm going to probably include as a canning pot and can sealer instruction booklets in PR #37263. This will both match how I'm finding canning books related to storing juice products online and also prevent any merge conflicts between the two PRs. I'll also give anothersimulacrum some time to look through and see if there's anything I need to do on his end of things. :) Thank you both! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, change the calories of orange juice to 108, and tests'll be done.
Co-Authored-By: anothersimulacrum <anothersimulacrum@gmail.com>
….com/Maleclypse/Cataclysm-DDA into Canning-Apple-Cider-and-other-juices
@I-am-Erk I think the failed C++ test is not due to anything in this PR. But I'm going to wait until you tell me this is good before I remove WIP. |
Need conflict resolution. |
Cool,now it's matched it to the books itemgroup updates from yesterday. |
Summary
SUMMARY: Content "Updated Canning Recipes to include the juices"
Purpose of change
Almost no fruit juices could be canned despite almost all fruit juices are able to be canned and saved. Here is one of several websites I checked out about canning fruit juice. https://inhabitat.com/how-to-can-fruit-and-veggie-juices-to-preserve-summers-sweetness/
Describe the solution
I added canning recipes and fixed missing byproducts in some juice production.
Describe alternatives you've considered
Selling the cherry orchard to an industrialist and leaving Vanya behind forgotten.
Testing
TBD
Additional context