Percent chance for AOE ammo effects #37190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[JSON]
ZhilkinSerg
force-pushed
the
refactor-ammo-effect-percent-chance
branch
from
9625eef to
de7ac79
Compare
ZhilkinSerg
force-pushed
the
refactor-ammo-effect-percent-chance
branch
from
de7ac79 to
21f4cc3
Compare
This was referenced Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Helps with #36900
Describe the solution
Refactor ammo effects to use percent (i.e.
x_in_100) chance instead ofone_inchance for AOE.Testing
Test that single affected ammo effect (
PLASMA) spawns field 50% of the time (one_in_2previously).Additional context
I did not rename json field and kept it name
chance. We can review this later.