NPC work log - for debugging and feedback #37300

ghost · 2020-01-22T11:12:10Z

Summary

SUMMARY: Features "NPC work log - for debugging and feedback"

Purpose of change

Adds a work log that lists NPC behaviour changes and mission changes and activity failures and reasons etc, to aid in debugging and giving feedback to the player.

Describe the solution

I kept promising myself I would add something like this before I added any new features to NPCs, debugging them and working out where they were going wrong was an exercise in frustration, I wanted a proper NPC activity test system too, but I thought something like this would help in that endeavour.

What this does is add a std::deque work log , every change in attitude, mission, activity and certian steps in activities, adds an entry to the log, with timestamp, character id, and a description of what changed, sometimes a tripoint and activity_reason_info too.

If debug mode is on, it lists everything, else, it just lists activity stuff.
Two ways to access it currently - from a basecamp bulletin board ,this will prefilter the log to show just the NPCs that are assigned to work at that camp.

You can also ask an NPC directly to tell you what their work log is, itll prefilter to just that NPC.

[WIP] because its rough, I would like to make it easier to read, prettier, easier to filter from within the window that pops up, perhaps add more categories of event, and ways to access it, so as to extract more relevant information and less filler.

Willing to accept guidance in this, but as it stands currently, its still useful for finding out why Bob failed to remove that vehicle part, or why he suddenly decided his mission was to run away or something, just gives a bit of an insight into their mind.

Describe alternatives you've considered

N/A

Testing

Asked NPC to do various things, assigned them to camp, opened work log, did the smae by talking to them directly.
Did this with debug mode on and off.

Tested save/load cycle to see that serial/deserial worked.

Additional context

Basic UI stuff.

src/npc.cpp

src/npc.h

src/savegame.cpp

src/savegame_json.cpp

src/npc.h

src/savegame_json.cpp

src/activity_handlers.h

src/activity_item_handling.cpp

kevingranade · 2020-01-27T09:23:42Z

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/basecamp-what-do-i-need-to-make-butchering-job-actually-work/22565/3

kevingranade · 2020-02-04T15:22:13Z

This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/how-does-npc-butchery-work/22654/11

first attempt at making an NPC work log serializing and expanding reasons sent to log clear folded list on display from review : shortern inserts Update src/npc.cpp Co-Authored-By: Jianxiang Wang (王健翔) <qrox@sina.com> Update src/npc.cpp Co-Authored-By: Jianxiang Wang (王健翔) <qrox@sina.com> Update src/npc.h Co-Authored-By: Jianxiang Wang (王健翔) <qrox@sina.com> Update src/npc.cpp Co-Authored-By: Jianxiang Wang (王健翔) <qrox@sina.com> remove unneeded lines test refactor to use enum strings move enum to string definitions to cpp from header Update src/savegame_json.cpp Co-Authored-By: Jianxiang Wang (王健翔) <qrox@sina.com> Update src/savegame_json.cpp Co-Authored-By: Jianxiang Wang (王健翔) <qrox@sina.com> fix up enum to string conversoin and default constructor added work log result for no candidates spaces to move components / cant see Update activity_item_handling.cpp shortern is_npc() checks commit to trigger rebuild

ghost · 2020-04-04T18:03:04Z

Rebased, cleaned up a bit, tested, working.

Still lots of refinements and additions that could be made to this, but the framework is there and the diff is getting big, as a first pass I consider this ready.

Qrox · 2020-04-05T06:43:00Z

Could you consider also migrating the UI code to use ui_adaptor/ui_manager?

ghost · 2020-04-05T10:30:16Z

Could you consider also migrating the UI code to use ui_adaptor/ui_manager?

Not familiar with that, and UI is my least favourite thing to do lol, but I'll take a look

Qrox · 2020-04-10T17:19:02Z

src/savegame_json.cpp

+    if( con_idx ) {
+        json.member( "con_idx", con_idx->id() );
+    } else {
+        json.member( "con_idx", -1 );


Suggested change

json.member( "con_idx", -1 );

json.null_member( "con_idx" );

For consistency with how cata::optional is written.

Qrox · 2020-04-10T17:19:30Z

src/savegame_json.cpp

+    JsonObject jo = jsin.get_object();
+    reason = jo.get_enum_value<do_activity_reason>( "reason" );
+    jo.read( "can_do", can_do );
+    if( jo.has_int( "index " ) ) {


Suggested change

if( jo.has_int( "index " ) ) {

if( jo.has_null( "con_idx" ) ) {

ZhilkinSerg · 2020-04-23T06:57:43Z

Feel free to reopen when you come back.

Qrox reviewed Jan 22, 2020

View reviewed changes

src/npc.h Outdated Show resolved Hide resolved

snipercup mentioned this pull request Jan 23, 2020

Spike Pit and Glass Pit Blueprint zone does not build over extant shallow pit #37297

Open

Qrox reviewed Jan 23, 2020

View reviewed changes

src/savegame_json.cpp Outdated Show resolved Hide resolved

src/savegame_json.cpp Outdated Show resolved Hide resolved

src/activity_handlers.h Outdated Show resolved Hide resolved

ghost mentioned this pull request Jan 23, 2020

Allow NPCs to use basecamp storage zone for activities/jobs #37325

Closed

BevapDin reviewed Jan 24, 2020

View reviewed changes

src/activity_item_handling.cpp Outdated Show resolved Hide resolved

This was referenced Jan 26, 2020

Weekly Digest (19 January, 2020 - 26 January, 2020) #37405

Closed

Weekly Digest (19 January, 2020 - 26 January, 2020) #37424

Closed

weekly-digest bot mentioned this pull request Feb 2, 2020

Weekly Digest (26 January, 2020 - 2 February, 2020) #37641

Closed

This was referenced Feb 9, 2020

Weekly Digest (2 February, 2020 - 9 February, 2020) #37848

Closed

Weekly Digest (2 February, 2020 - 9 February, 2020) #37851

Closed

Weekly Digest (9 February, 2020 - 16 February, 2020) #38055

Closed

weekly-digest bot mentioned this pull request Feb 16, 2020

Weekly Digest (9 February, 2020 - 16 February, 2020) #38058

Closed

ghost mentioned this pull request Feb 24, 2020

False warning spam during zone deconstruction #38264

Closed

This was referenced Feb 27, 2020

Butcher corpses zone activity sporadically fails #38415

Open

NPCs no longer plant tiles #38565

Closed

ghost requested review from I-am-Erk and John-Candlebury as code owners March 6, 2020 19:16

ghost changed the base branch from master to dev March 6, 2020 19:17

ZhilkinSerg force-pushed the dev branch 2 times, most recently from aa39539 to 9761f13 Compare March 10, 2020 09:21

ZhilkinSerg force-pushed the dev branch from 1bd931d to 392182e Compare March 15, 2020 11:59

ZhilkinSerg force-pushed the dev branch 5 times, most recently from 924f105 to 39e00e3 Compare March 18, 2020 07:00

ZhilkinSerg force-pushed the dev branch 3 times, most recently from ad63e77 to 8e68539 Compare April 1, 2020 12:18

kevingranade force-pushed the dev branch 4 times, most recently from 621a68e to b7106d0 Compare April 2, 2020 07:42

ZhilkinSerg force-pushed the dev branch 3 times, most recently from 0f30a43 to d432807 Compare April 2, 2020 12:55

ZhilkinSerg changed the base branch from dev to master April 2, 2020 14:31

davidpwbrown added 5 commits April 4, 2020 15:15

con idx as construction_id

fab4469

serialize new construction_id from activity_reason_info

8335c1f

redundant redeclaration removal

16a2481

fix up, clean up little bugs, optimize scanning

ef1b38e

ghost changed the title ~~[WIP]NPC work log - for debugging and feedback~~ NPC work log - for debugging and feedback Apr 4, 2020

ifreund removed the 0.E Feature Freeze label Apr 4, 2020

Qrox reviewed Apr 10, 2020

View reviewed changes

ZhilkinSerg added the stale-D label Apr 23, 2020

ZhilkinSerg closed this Apr 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NPC work log - for debugging and feedback #37300

NPC work log - for debugging and feedback #37300

ghost commented Jan 22, 2020 •

edited by ghost

Loading

kevingranade commented Jan 27, 2020

kevingranade commented Feb 4, 2020

ghost commented Apr 4, 2020 •

edited by ghost

Loading

Qrox commented Apr 5, 2020

ghost commented Apr 5, 2020

Qrox Apr 10, 2020

Qrox Apr 10, 2020

ZhilkinSerg commented Apr 23, 2020

	if( jo.has_int( "index " ) ) {
	if( jo.has_null( "con_idx" ) ) {

NPC work log - for debugging and feedback #37300

NPC work log - for debugging and feedback #37300

Conversation

ghost commented Jan 22, 2020 • edited by ghost Loading

Summary

Purpose of change

Describe the solution

Describe alternatives you've considered

Testing

Additional context

kevingranade commented Jan 27, 2020

kevingranade commented Feb 4, 2020

ghost commented Apr 4, 2020 • edited by ghost Loading

Qrox commented Apr 5, 2020

ghost commented Apr 5, 2020

Qrox Apr 10, 2020

Choose a reason for hiding this comment

Qrox Apr 10, 2020

Choose a reason for hiding this comment

ZhilkinSerg commented Apr 23, 2020

ghost commented Jan 22, 2020 •

edited by ghost

Loading

ghost commented Apr 4, 2020 •

edited by ghost

Loading