#37537 make lit candle a firestarter #37547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[JSON]
|
Simple but nice change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Lit candle is now a firestarter"Purpose of change
Fixes #37537
Previously, lit candles did not have the FIRESTARTER flag, so you couldn't light a candle (or other things) with a lit candle. This was presumably an oversight caused by the fact that in most cases, when you have a lit candle, you will also hold the thing used to light that candle.
Describe the solution
Just added the FIRESTARTER flag to candle_lit.
Describe alternatives you've considered
I checked out if maybe this was intentional, or if it leads to an exploit. I don't think so -- IRL you certainly can use a candle to light a candle.
I looked at the code to see if FIRE or FLAMING were also flags that should be added, but I don't think they are.
The other alternative was doing nothing.
Testing
Before and after, tested lighting candles with candles, lighting fires, and lighting the charcoal smoker and metal smoking rack. They all now work.