-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change food recipes in minor ways to improve utelization of ingredients #37604
Conversation
Fiddleheads should be more well integrated into the game. I've added them to any_veggy and removed the ability to boil fiddleheads in broth to avoid recursion errors
Added a requirement list including cooking oils and butter, because many recipes should work fine with any of them
So I can test the "any_butter_or_oil" requirement I swapped out the cooking oils for it
notes for mergers: if travis fails make sure the recipe permutation test isn't the reason. |
I ran a simple test, seeing if I could craft pancakes with butter. Worked fine. I'm gonna edit recipe_food.json next. Tests to follow
it looks like you've done something to the tileset config. |
For when you want the food to absorb some of the fat it's being deep fried in. Potato chips and French fries both use fry_oil, which contains cooking_oil, cooking_oil2, and ghee. All tested. Works properly for me
Changed a bunch of recipes to use any_butter_or_oil. Tested each one. Seems to work fine
Lots of additions. Everything seems good to me. I've tested every recipe I've changed. |
I'm not sure how things keep changing that I'm not editing. I'm not even sure what files those are in. Is it still an issue? I may have taken care of it |
Thanks for looking. I have no idea at all how that got changed. I have never opened the folder that's in, let alone the file. Bizarre |
Commited in the be9bbc4. Probably changed by json linter. |
I made fried liver and fried tripe use fry_oil Canged some pan frying oils to any_butter_or_oil Added boiled and sauteed fiddleheads to salad recipe Added salsify_baked to any_veggie
I hope I took care of the differences in the tile_config file |
|
Thanks for explaining that to me. I had no idea what it was talking about. On it! |
Tweaked it further trying to beat this dang thing. |
Is there anything left that needs done here? |
I was just waiting for the CI tests to pass. It looks like they passed on the last version - if the CI tests are all good and there's no conflict I don't recommend updating your branch with upstream, as it just resets the CI tests. |
Thanks for the tip, and the merge. Much obliged |
Summary
SUMMARY: Content "Recipe Realism"
Purpose of change
As things are added to the game it's useful to go through the recipes and make sure that newer ingredients are as well implemented as they could be in the current recipes
Describe the solution
I've gone through the recipes, cooking tools, and cooking requirements and increased access to butter across many recipes where it made sense. I added boiled fiddleheads and roasted salsify to veggy_any, so they could be usable in many more recipes.
Describe alternatives you've considered
I've been thinking of ways to expand and improve upon the cooking system. These small edits are minor but working with them has prepared me for more ambitious goals. Perhaps a baking system with ovens that work a lot like smoking racks. It'd take redoing many of the recipes, but it's an alternative I've considered
Testing
I've tested each change. Every recipe works with the new ingredients.
Additional context
I find myself wondering if sauteed fiddleheads would be a decent addition to veggy_any, or if the inherited fat calories be inappropriate?