item_groups.json sort 7 #37631
Merged
item_groups.json sort 7 #37631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created 1 new .json (electronics); renamed monster_drops to monster_drops_lairs to reflect the file now containing lair item lists; moved various other item lists.
I-am-Erk
reviewed
Feb 2, 2020
| @@ -1860,5 +1860,32 @@ | |||
| [ "recipe_fauxfur", 5 ], | |||
| [ "textbook_tailor", 3 ] | |||
| ] | |||
| }, | |||
| { | |||
| "id": "casings", | |||
There was a problem hiding this comment.
This definitely is too general to belong in locations_commercial, even if it was originally for a shooting range
There was a problem hiding this comment.
I've now moved casings to ammo.json instead
This was referenced Feb 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "created electronics.json; renamed monster_drops to monster_drops_lairs to reflect the file now containing lair item lists as well as drops; moved various other item lists to respective .jsons."Purpose of change
item groups tidying
Describe the solution
Testing
linted files, spawned lists in-game.
Additional context
I'm not always 100% sold on starting new .jsons to contain a list or two of item spawns (this is about tidying and de-cluttering, after all), but I also don't imagine what I'm doing is a permanent fix. Above all, I don't think it's helpful having both an item_groups.json and a misc.json, as they seem to be the same thing. Any feedback is welcome.