Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gun volume auditing for .32 #37637

Merged
merged 3 commits into from Feb 4, 2020
Merged

Gun volume auditing for .32 #37637

merged 3 commits into from Feb 4, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2020

Summary

SUMMARY: Content "Realistic gun volumes for .32"

Purpose of change

Helps #37374.

Describe the solution

Change gun volume to side surface area times width.

Describe alternatives you've considered

None.

Testing

Loaded ingame.

Additional context

Skorpion Vz. 61, overall length 270mm and width 45mm: https://www.armimilitari.it/wordpress/wp-content/uploads/2014/07/sa-vz-61-skorpion-pistol-instruction-manual.pdf
Removing the magazine: https://imgur.com/a/oq8wTxB
Coloring in light areas to make Binary option work: https://imgur.com/a/WEKWCZJ
Results: https://imgur.com/a/1n76Xj6

SIG Sauer P230(Using the updated P232's manual), overall length 6.60" and width 1.2": http://pdf.textfiles.com/manuals/FIREARMS/sig_p232.pdf
Results: https://imgur.com/a/DcVMeLu

Walther PPK, overall length 6.1" and width 1": https://waltherarms.com/ppk-2/
Removal of magazine + filling in light areas for Binarization: https://imgur.com/a/vL5evpY
Results: https://imgur.com/a/kyvQw0V

@ghost ghost changed the title Gun volume audit for .32 Gun volume auditing for .32 Feb 2, 2020
@ghost ghost marked this pull request as ready for review February 2, 2020 20:12
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact <Bugfix> This is a fix for a bug (or closes open issue) labels Feb 2, 2020
@I-am-Erk I-am-Erk merged commit cb9b93e into CleverRaven:master Feb 4, 2020
@ghost ghost deleted the Audit32over100 branch February 5, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants