Gun volume audit for .357 SIG + adjust SIG Sauer weights #37670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
ghost
changed the title
ZhilkinSerg
added
[JSON]
This was referenced Feb 9, 2020
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Realistic gun volumes for .357 SIG"Purpose of change
Helps #37374. Also the SIG Sauer weights were slightly off.
Describe the solution
Gun volume as surface area times width.
Describe alternatives you've considered
None.
Testing
Loaded ingame.
Additional context
Sig Sauer P226(using E26R-9-LEGION model, as it's the only DA/SA with 15rnd mag like the ingame description), overall length 20.3cm and width 3.8cm: https://www.sigsauer.com/store/p226-legion-full-size.html
Results: https://imgur.com/a/LehCJzT
Glock 31, overall length 20.4cm and width 3.2cm: https://us.glock.com/en/pistols/g31
Results: https://imgur.com/a/DT51ZrF
SIG Sauer P320(320C-357-BSS is their only .357 SIG version), overall length 18.3cm and width 3.4cm: https://www.sigsauer.com/store/p320-nitron-compact.html
Results: https://imgur.com/a/oRrsw5p
Note: P320's magazine has one higher capacity than real life, which will be fixed in another PR.