Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gun volume audit for .38 Super #37676

Merged
merged 2 commits into from Feb 4, 2020
Merged

Gun volume audit for .38 Super #37676

merged 2 commits into from Feb 4, 2020

Conversation

ghost
Copy link

@ghost ghost commented Feb 3, 2020

Summary

SUMMARY: Content "Realistic gun volumes for .38 Super"

Purpose of change

Helps #37374.

Describe the solution

Gun volume as side-view surface area times width.

Describe alternatives you've considered

Using the thicker 1.406" width for the M1911A1 from the .45 ACP models(495ml).

Testing

Loaded ingame.

Additional context

AF2011A1: weight 4.5lb(2041g), total length 8.6" and width 1.9"(from their U.S. distributor): https://issuu.com/intlfirearmcorp/docs/arsenal_firearms_of_italy
Removing gray background so Binarization works: https://imgur.com/a/b0MmuKT
Results: https://imgur.com/a/4Cna2Pu

M1911A1:
Total length of 8.56", weight of 2.55lb, and picture from: https://www.classicfirearms.com/rock-island-armory-1911-38sa-pistol-9rd-ria-51815/
Width of 1.313" from the same company: https://armscor.com/firearms/ria/rock-series/
Results: https://imgur.com/a/qMwqnMd

@ghost ghost marked this pull request as ready for review February 3, 2020 21:36
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Items / Item Actions / Item Qualities Items and how they work and interact <Bugfix> This is a fix for a bug (or closes open issue) labels Feb 4, 2020
@I-am-Erk I-am-Erk merged commit 68609c4 into CleverRaven:master Feb 4, 2020
@ghost ghost deleted the Audit38Super branch February 5, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants