update mutations.json

[wingbrother]

Summary

SUMMARY: Bugfixes "change bad and good memory traits to match the new skill rust system"

Describe the solution

In new skill rust system increasing skillrust rate increase time between skill rusting. Old good memory traits decrease time (accelerate skillrusting instead of slowing down) in new system. Inversing skill_rust_multiplier between FORGETFUL and GOODMEMORY traits.

[ZhilkinSerg]

GOODMEMORY trait had multiplier of 0.66 and FORGETFUL trait had multiplier of 1.33 for skill_rust_multiplier both before and after it was jsonized in #32337. I don't remember anything changed regarding skill rust system recently that need to swap multiplier values between traits.

[wingbrother]

in
bool SkillLevel::rust
if( to_turns( skill_rate ) * char_rate <= 0 || delta <= 0_turns ||
delta % ( skill_rate * char_rate ) != 0_turns ) {
return false;
}

in
int Character::rust_rate() const
*ret = mutation_value( "skill_rust_multiplier" );

I highlighted those parts due to which skill ratе need swaping

[ZhilkinSerg]

That is not something new then - it was always % operator at least back to 0.A.

bool SkillLevel::rust(const calendar& turn, bool charged_bio_mem)
{
    if (_level > 0 && turn > _lastPracticed &&
       (turn - _lastPracticed) % rustRate(_level) == 0)

[wingbrother]

earlier skill_rust_multiplier used to change the probability of a decrease in skills; now it affects the time between skill losses.

int ret = ( ( get_optionstd::string( "SKILL_RUST" ) == "vanilla" ||
get_optionstd::string( "SKILL_RUST" ) == "capped" ) ? 100 : 100 + 10 * ( intel - 8 ) );

high intellect increase rust_rate

sorry for my bad english.

[Fris0uman]

Yep this #37281 changed what the rate means, sorry for not catching the mutation thing.