Clearer message when safecracking with music playing #38003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes mp3 players take the same amount of time to activate or deactivate as music-playing smartphones. PR CleverRaven#37584 added 200 (de-)activation time to the smartphones, but since the mp3 player already had its own 200 move cost, this made the mp3 player take twice as long as the other devices.
Previous message was vague Fixes CleverRaven#37996
ZhilkinSerg
added
<Bugfix>
This was referenced Feb 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Clearer message when safecracking with music playing"Purpose of change
Fixes #37996
Describe the solution
Change the message from:
to:
Also removes a double-activation-time cost for mp3 players that was caused by PR #37584 (which added 200 moves to all devices but didn't remove the existing 200 moves for mp3 players in particular).
Describe alternatives you've considered
Considered also indicating the device type as well, but I see the mp3 on/off functions are already cluttered with multiple hardcoded device types after the above PR, and all of this would have to be duplicated in the safe-cracking code too, and I am not interested in opening that can of worms.
Testing
Additional context