Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canning juices now results in canned products #38062

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

jkraybill
Copy link
Contributor

Summary

SUMMARY: Content "Canning juices now results in canned products instead of plastic bottles"

Purpose of change

Fixes #38060. The problem was that the recipes in canned.json did not specify containers, which works for canning things whose default container matches the canning recipe, but for things where the default container is a plastic bottle, the results were being contained in that.

Describe the solution

Changed the canning recipes for canned OJ, fruit juice, apple cider, and cranberry juice to be contained in medium cans. Did not change any of the recipes otherwise.

Describe alternatives you've considered

Looked at whether it was worth changing to small cans. I think this is a question worth revisiting when #37551 is tackled.

Testing

Made all recipes before and after the change. Verified they become contained in medium cans with the expected charges.

I did a pass of the other recipes in canned.json to verify that all the other default-container recipes get contained in actual cans.

Additional context

#37551 and #37504 are in the same realm but require a bit more analysis before properly addressing.

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks labels Feb 16, 2020
@ZhilkinSerg ZhilkinSerg merged commit 187853e into CleverRaven:master Feb 16, 2020
@jkraybill jkraybill deleted the 38060b branch February 17, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crafting canned fruit juice yield's plastic bottles of fruit juice.
2 participants