-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor non-waiting popups using ui_adaptor #39054
Conversation
f8a5ec4
to
0e1c29d
Compare
…oading_ui & main_menu
These are expected before all menus are migrated to I'll add |
Makes sense. No rush about it - I still need to merge |
Summary
SUMMARY: Interface "Refactor non-waiting popups using ui_adaptor"
Purpose of change
Replace
popup_nowait
andpopup_status
with a new classstatic_popup
that properly handles redrawing and resizing.Describe the solution
static_popup
that displays a popup without taking inputs.background_pane
that obscures all UIs below.static_popup
andbackground_pane
in place ofpopup_nowait
,popup_status
, andcatacurses::erase()
.Testing
Tested in game and popup worked as intended in normal gameplay as well as after resizing. Some popups were not tested specifically, such as the save migration popup, because I didn't have a save to test.