Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for AFS Mastadon: Mutations #39573

Merged
merged 9 commits into from Apr 28, 2020
Merged

Fix for AFS Mastadon: Mutations #39573

merged 9 commits into from Apr 28, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 14, 2020

Summary

SUMMARY: Bugfixes "Fix mastodon mutation line"

Purpose of change

Fixes issues with the new mastodon mutations from #37660.

Fixes #39627.

Describe the solution

  1. Define the mutation category so mutagen/serum can be used without crashing the game.
  2. Alter mutations to use extensions where applicable & not be taken at chargen.
  3. Change Uplifted Enforcer's mutations based on input from @Maleclypse.
  4. Move mutations into the mutations folder. Delete original player/mutations folder.
    4b. Move obsolete.json from player to mutations folder.

Describe alternatives you've considered

None.

Testing

1-Loaded ingame, without errors, as Uplifted Enforcer.
2- Drank & injected mastodon mutagen & serum, no crash as was previous.
2a- Spawned in with no mutations, spammed mastodon serum to check if obsoletes were still showing up. They weren't.
2b- Spawned in with no mutations, spammed mastodon serum to become a Killophant

Additional context

@Maleclypse
Copy link
Member

"traits": [ "PROF_SWAT", "UPLIFTED", "THRESH_MASTODON", "MUT_TOUGH", "TUSKS", "HUGE_OK", "LARGE_DIET" ], so these are the traits I'm thinking the profession should start with and I've been messing with changing the point cost between 7 and 9 instead of 13

@ZhilkinSerg ZhilkinSerg added the Mods: Aftershock Anything to do with the Aftershock mod label Apr 15, 2020
@ghost
Copy link
Author

ghost commented Apr 26, 2020

Uplifted Enforcer after adjustment:
image
image
@Maleclypse has stated he will add XL socks & undergarments to mainline to fix the removal of those.

@ghost ghost marked this pull request as ready for review April 26, 2020 17:34
@ghost ghost requested a review from John-Candlebury as a code owner April 26, 2020 17:34
@ghost
Copy link
Author

ghost commented Apr 26, 2020

Having issues with still getting the obsolete mutations when injecting serum 😕

Edit: Is fixed now.

@ZhilkinSerg ZhilkinSerg merged commit d78062e into CleverRaven:master Apr 28, 2020
@ghost ghost deleted the MastaMutations branch April 28, 2020 16:01
Drewscriver pushed a commit to Drewscriver/Cataclysm-DDA that referenced this pull request Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mods: Aftershock Anything to do with the Aftershock mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Aftershock] two instances High thirst in character creation
3 participants