-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new starting scenario The Last Delivery #39703
Conversation
{ | ||
"type": "COMESTIBLE", | ||
"id": "foodplace_food", | ||
"name": { "str": "Foodplace's delicious food™", "str_pl": "Foodplace's delicious food™" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't all these words be capitalized, since it's a branded product?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'll keep it like that.
No platinum chip references? |
Nah, we have enough fallout references already. |
Isn't this duplicating the functionality of #37314 ? |
Nop it adds to it, that PR allowed professions to to specify vehicles this allows scenarios to do the same. |
And what are they? Besides power armor, which, honestly, isn't specifically Fallout-y. |
|
|
The eyebot is also a Fallout reference (even though we changed the description to be a quadcopter drone) and there might be a few others. In any case I'm really not interested in putting a fallout reference in that scenario. |
"type": "mission_definition", | ||
"name": { "str": "Reach The Mansion And Finish This Delivery" }, | ||
"goal": "MGOAL_GO_TO_TYPE", | ||
"destination": "mansion_c3_north", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be mansion_c3
to work on terrains with all rotations (see #40185).
Summary
SUMMARY: Content " Add new starting scenario The Last Delivery "
Purpose of change
Add a new starting scenario
Add the ability to specify vehicles in scenarios
Expand Foodplace's lore a tiny bit
Describe the solution
Add starting_vehicle entry to scenarios
Add UI support to display starting vehicles
Add new vehicle, new quest and new food item to make the scenario
Describe alternatives you've considered
Testing
Chose
The Last Delivery
Spawn properly
Get the vehicle
Thing Spawn properly in it
Additional context
Sometimes the food truck will spawn embedded into other vehicles, I don't know how to fix that.