Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new starting scenario The Last Delivery #39703

Merged
merged 7 commits into from
Apr 21, 2020

Conversation

Fris0uman
Copy link
Contributor

@Fris0uman Fris0uman commented Apr 18, 2020

Summary

SUMMARY: Content " Add new starting scenario The Last Delivery "

Purpose of change

Add a new starting scenario
Add the ability to specify vehicles in scenarios
Expand Foodplace's lore a tiny bit

Describe the solution

Add starting_vehicle entry to scenarios
Add UI support to display starting vehicles
Add new vehicle, new quest and new food item to make the scenario

Describe alternatives you've considered

Testing

Chose The Last Delivery
Spawn properly
Get the vehicle
Thing Spawn properly in it

Additional context

Sometimes the food truck will spawn embedded into other vehicles, I don't know how to fix that.

data/json/npcs/missiondef.json Outdated Show resolved Hide resolved
{
"type": "COMESTIBLE",
"id": "foodplace_food",
"name": { "str": "Foodplace's delicious food™", "str_pl": "Foodplace's delicious food™" },
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't all these words be capitalized, since it's a branded product?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll keep it like that.

@Night-Pryanik
Copy link
Contributor

No platinum chip references?

@Fris0uman Fris0uman marked this pull request as ready for review April 19, 2020 09:06
@Fris0uman
Copy link
Contributor Author

Nah, we have enough fallout references already.

@Amoebka
Copy link
Contributor

Amoebka commented Apr 19, 2020

Isn't this duplicating the functionality of #37314 ?

@Fris0uman
Copy link
Contributor Author

Nop it adds to it, that PR allowed professions to to specify vehicles this allows scenarios to do the same.

@Night-Pryanik
Copy link
Contributor

Nah, we have enough fallout references already.

And what are they? Besides power armor, which, honestly, isn't specifically Fallout-y.

@ghost
Copy link

ghost commented Apr 20, 2020

And what are they?

  1. Razorclaws aka Mirelurks
  2. Mininukes(and formerly the Fat Man before that got obsoleted)

@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Scenarios New Scenarios, balancing, bugs with scenarios labels Apr 20, 2020
@Night-Pryanik
Copy link
Contributor

  1. Razorclaws are non-bipedal, unlike Mirelurks. Also there are lot of other sources of mutated crustaceans besides Fallout.
  2. Mininuke is (was) a RL thing. Also IIRC in Cataclysm it was never referenced as a "Fat Man".

@Fris0uman
Copy link
Contributor Author

Fris0uman commented Apr 20, 2020

The eyebot is also a Fallout reference (even though we changed the description to be a quadcopter drone) and there might be a few others. In any case I'm really not interested in putting a fallout reference in that scenario.

@ZhilkinSerg ZhilkinSerg merged commit 449b326 into CleverRaven:master Apr 21, 2020
@Fris0uman Fris0uman deleted the last_delivery branch April 21, 2020 07:15
"type": "mission_definition",
"name": { "str": "Reach The Mansion And Finish This Delivery" },
"goal": "MGOAL_GO_TO_TYPE",
"destination": "mansion_c3_north",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be mansion_c3 to work on terrains with all rotations (see #40185).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Scenarios New Scenarios, balancing, bugs with scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants