Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spells to spawn items with their containers #40097

Merged

Conversation

RedShakespeare
Copy link
Contributor

@RedShakespeare RedShakespeare commented May 3, 2020

Summary

SUMMARY: Features "Allow spells to spawn items with their containers"

Purpose of change

In current version if we want to use a spell to spawn something in liquid phase we have to prepare a container in advance or that item would fall onto ground. This pr is aimed to allow liquid spawned with containers.

Describe the solution

Add a "WITH_CONTAINER" flag for spells to spawn items with containers.

Describe alternatives you've considered

Let "effect_str" works as item_groups, not items (but that will lead to a thorough rewrite in current spells' definitions).

Testing

Not yet...but it should work technically.

Additional context

This could be used for future furnitures like sacrificial altar or something.

Add a "WITH_CONTAINER" flag for spells to spawn items with containers.
@RedShakespeare RedShakespeare requested a review from KorGgenT as a code owner May 3, 2020 06:02
@KorGgenT
Copy link
Member

KorGgenT commented May 3, 2020

please update the docs in flags.json and JSON_FLAGS.md

@RedShakespeare
Copy link
Contributor Author

please update the docs in flags.json and JSON_FLAGS.md

Gotta do that immediately.
( But there's no flag about spells in JSON_FLAGS.md ... I'm not quite sure where I should add this in.

Add description about flag "WITH_CONTAINER"
@KorGgenT
Copy link
Member

KorGgenT commented May 3, 2020

oh i thought i put something in the markdown file. if i didn't then i guess i just did the json file as documentation

@RedShakespeare
Copy link
Contributor Author

RedShakespeare commented May 3, 2020

so it is. wwwwwwww
and....mission accomplished ( lol

@KorGgenT KorGgenT merged commit b546c20 into CleverRaven:master May 3, 2020
@RedShakespeare RedShakespeare deleted the spawn_item_with_container branch May 4, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants