Move bionic_data to generic_factory #40155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there: https://discourse.cataclysmdda.org/t/bionics-json-and-inheritance-override/23543/2 |
|
Fixes #37476 (stale). |
mlangsdorf
added
Bionics
jbytheway
reviewed
May 7, 2020
Comment on lines
-2712
to
-2719
| void finalize_bionics() | ||
| { | ||
| for( const std::pair<const bionic_id, bionic_data> &bio : bionics ) { | ||
| if( bio.second.upgraded_bionic ) { | ||
| bionics[ bio.second.upgraded_bionic ].available_upgrades.insert( bio.first ); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
How were you able to remove the finalization step without changing the bionics json? I feel like you should still need some code like this somewhere, but I don't see it.
There was a problem hiding this comment.
It's because the only thing in the repo using this is the obsolete reactor CBM. But I should probably add an entry about it to the doc though.
Merged
This was referenced May 10, 2020
helariII
referenced
this pull request
in helariII/Cherry-Pick-Move-bionic_data-to-generic_factory
May 23, 2021
helariII
referenced
this pull request
in helariII/Cherry-Pick-Move-bionic_data-to-generic_factory
May 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Infrastructure "Move bionic_data to generic_factory"
Purpose of change
Modernise bionic code and should enable
copy-fromfor CBMsDescribe the solution
Move bionic_data to generic_factory
Get rid of get_bool_or_flag implementation in favor of flags
Implement flags
Describe alternatives you've considered
Testing
Instal finger laser and power bank MK II
Shoot zombies
No problem
Create an override of Air filtration system using copr-from
Replace 7 mouth protection by 70 eyes protection in env_protect
Get a CBM with 70 eyes Ep
Try again but just change the name
Spawn and install the CBM and have only the name change
Make another CBM with a new id and use copy from
The CBM has the properties of the copied from bionic
Additional context
Using clear() in load_bionic for stdd::map is not super elegant
Also just making a new CBM, in a mod, with the same id as a vanilla one without copy from seem to work without errors, I don't know if that's a problem.