Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence erroneous lgtm alert by making a dead throw correct #40245

Merged
merged 3 commits into from
May 6, 2020
Merged

Silence erroneous lgtm alert by making a dead throw correct #40245

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6802f34
Silence erroneous lgtm alert by making a dead throw correct
kevingranade May 6, 2020
1036574
Astyle
kevingranade May 6, 2020
53c61f4
just a string
kevingranade May 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/units.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,7 @@ T read_from_json_string( JsonIn &jsin, const std::vector<std::pair<std::string,
}
error( "invalid quantity string: unknown unit" );
// above always throws but lambdas cannot be marked [[noreturn]]
throw;
throw std::exception("Exceptionally impossible");
kevingranade marked this conversation as resolved.
Show resolved Hide resolved
};

if( skip_spaces() ) {
Expand Down