Behavior tree special attack integration #40555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
force-pushed
the
behavior-tree-special-attack-integration
branch
4 times, most recently
from
1fbde55 to
73275e9
Compare
|
Tested out fine, the only thing I might add here is documentation on how behavior -> special attack correspondence works, but if you merge it before that goes in I'll just add it in another PR. |
|
Hooray, weird crash in tests I didn't encounter locally. |
kevingranade
force-pushed
the
behavior-tree-special-attack-integration
branch
from
73275e9 to
976567c
Compare
…e with first special
kevingranade
force-pushed
the
behavior-tree-special-attack-integration
branch
from
976567c to
23551fe
Compare
|
The crash is legit. I've resolved it now it was a data error and I've also corrected the issue that escalated the data issue to be a crash. |
ZhilkinSerg
added
<Enhancement / Feature>
ZhilkinSerg
reviewed
May 25, 2020
| CHECK( monster_goals.tick( &oracle ) == "idle" ); | ||
| for( const tripoint &near : g->m.points_in_radius( monster_location, 1 ) ) { |
There was a problem hiding this comment.
It is ridiculous, but you can't use near as variable name in VS.
There was a problem hiding this comment.
Gah, yes I've seen that before, I need to add a lgtm filter or something to warn on this and other VS reserved words.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Continuing #39810
tl;dr the monster AI code is inflexible and difficult to extend, this is part of the process of migrating the whole thing to use behavior trees to make it more legible and flexible.
Describe the solution
This addresses most of the major blockers to onboarding special attacks to behavior trees.
Extends the behavior predicate API to accept an optional argument and use it to specify a special id to check for. This avoids having to add a predicate for each special, and I anticipate this sort of thing coming up repeatedly.
Adds predicates as needed to determine whether the target special is triggerable.
Added code to inject the behavior tree definition into monster types that have the special.
Added code to invoke the special attack if selected.
Testing
Extended the unit test I added previously.
Need to spawn in a locust and induce it to nibble some plants.
Additional context
Great resource for behavior trees: http://www.gameaipro.com/GameAIPro/GameAIPro_Chapter06_The_Behavior_Tree_Starter_Kit.pdf