Make behavior conditions a list of objects #40984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevingranade
force-pushed
the
behavior-condition-array
branch
3 times, most recently
from
f5ae43e to
43e05c8
Compare
anothersimulacrum
added
[C++]
kevingranade
commented
May 31, 2020
kevingranade
commented
May 31, 2020
kevingranade
force-pushed
the
behavior-condition-array
branch
from
dd8a01f to
2e30077
Compare
anothersimulacrum
added
the
Code: Infrastructure / Style / Static Analysis
This allows for fewer behavior nodes when multiple conditions must be checked.
kevingranade
force-pushed
the
behavior-condition-array
branch
from
2e30077 to
88a3115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
I noticed as of #40555 that behavior nodes were becoming way too verbose as multiple conditions were used per action, but I didn't want to shoehorn this change into that PR.
Describe the solution
Change the behavior::node::predicate entry into a behavior::node::conditions list that allows multiple predicates (and arguments) to be added to a single behavior node.
Describe alternatives you've considered
None really, this is a pretty basic functionality of behavior trees that I missed in my initial implementation.
Testing
Unit tests should still pass. (duh)
Shoggoth and locust special attacks should still trigger.