Gun volume audit for 5.56, part 1 #41394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
[JSON]
ghost
marked this pull request as ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: NonePurpose of change
Helps #37374.
Describe the solution
Adjust volume & longest_side based on ImageJ calculations.
Describe alternatives you've considered
None.
Testing
Looking at guns ingame.
Additional context
Doing this one in multiple parts due to the high volume(pun not intended) of entries.
Redoing MAS .223 since it was originally measured in #38683 with the magazine in:
MAS .223, OAL 757mm and unloaded weight 3.61kg: http://www.nazarian.no/images/wep/461_MAS_223_en_manual.pdf
Using 1:1 airsoft reconstruction to get all views: https://www.evike.com/products/32598/
Magazine removal: https://imgur.com/a/mP4V1i1
Width after scaling to OAL: https://imgur.com/a/7dhEMy5
SA+Feret: https://imgur.com/a/fGelovS
FS2000, already volume & weight auditted in #36838
Feret after removing magaine: https://imgur.com/a/ZtHIOyL
AR pistol from #37768, OAL 23" : http://www.gunsholstersandgear.com/gun-reviews/diamondback-db15-pistol-review/
Magazine removal: https://imgur.com/a/NujmOrZ
Feret(original PR that added longest_length was done in the wrong file): https://imgur.com/a/AoY3Wlo
HK416 A5, collapsed OAL 797mm & width 74mm: https://www.heckler-koch.com/en/products/military/assault-rifles/hk416-a5/hk416-a5-145/technical-data.html
Magazine removal & iron sight flipdown: https://imgur.com/a/zI19yPI
SA+Feret: https://imgur.com/a/C1pRmqk