Audit .308/7.62x51 type guns #41698
Closed
Audit .308/7.62x51 type guns #41698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change batch time savings when crafting clean water from 80% at >4 units to 20% at >1 unit
This door can only be used by a mary poppins
anothersimulacrum
added
[JSON]
Fix Unexpected msg
Remove a pointless door
Actual requested item is knife_spear_superior not knife_spear. fixes CleverRaven#41560
|
So, where did you put the sources for your lengths & widths of each gun? |
* new workout equpment mapgen distribution * serialize & deserialize variables
* add alternate recipe for slam_fire shotgun. No welder this time, and it's given right off the bat! Say hello to your new early early-game shotgun!
…aterBatchSavings Make clean water batch time saving more realistic
Ground vehicle z-level transitions requires that z-levels be enabled, and getting rid of this option will also allow much of the map code to be dramatically simplified.
…e-spear-quest Fix MISSION_RANCH_SCAVENGER_1 required item
I'll provide a complete reference list for all the guns in json/items/gun/308.json when I'm finished. |
feinorgh
changed the title
|
It looks like I did a boo-boo when solving a conflict. Will make a new pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Content "Audit volume and longest_side for .308 type guns"
Purpose of change
Audit volume and longest_side to .308 type guns as realistically as possible, as a part of #37374 and #41691
Describe the solution
Added longest_side taken from representative versions of each gun, estimating volumes from the method described in #37374.
Describe alternatives you've considered
n/a
Testing
Each gun is spawned into debug mode and checked.
Additional context
For some guns it's difficult to ascertain proper widths. Where it's known, I've taken these values from Wikipedia or each respective manual, but usually only the maximum width is shown, as for the M240/FN MAG, which states its width to be 120 mm wide. Having used an FN MAG, I know it's not uniformly 120 mm wide -- more like 60 to 80 mm wide, so I estimated what I believed to be a reasonable value that produced a somewhat credible volume in the end.
These values might need some more research and/or actual volume measurements from real weapons (say, a submersion test in water if anyone happens to own the specific gun, a practical tub to measure the level in and some waterproof snug container).
Sources for each changed weapon:
FN FAL
https://en.wikipedia.org/wiki/FN_FAL
http://www.smallarmssurvey.org/fileadmin/docs/weapons/SAS-weapons-rifles-FN-FAL.pdf
H&K G3
https://en.wikipedia.org/wiki/Heckler_%26_Koch_G3
https://modernfirearms.net/en/assault-rifles/germany-assault-rifles/hk-g3-eng/
https://www.militaryfactory.com/smallarms/detail.asp?smallarms_id=127
M134D-H Minigun
https://en.wikipedia.org/wiki/Minigun
https://dillonaero.com/product/hybrid-m134d/
https://www.militaryfactory.com/smallarms/detail.asp?smallarms_id=243
M14 EBR-RI
https://en.wikipedia.org/wiki/Mk_14_Enhanced_Battle_Rifle
https://www.militaryfactory.com/smallarms/detail.asp?smallarms_id=377
M1A
https://en.wikipedia.org/wiki/Springfield_Armory_M1A
https://www.springfield-armory.com/m1a-series-rifles/m1a-standard-issue-rifles/m1a-standard-issue-308-rifle/
M240
https://en.wikipedia.org/wiki/M240_machine_gun
https://www.fnherstal.com/en/product/fn-mag
M60
https://en.wikipedia.org/wiki/M60_machine_gun
http://www.usord.com/content/docs/datasheets/USORD_M60E6_10.17.pdf
Savage 111F
https://en.wikipedia.org/wiki/Savage_Model_110
https://www.savagearms.com/content?p=firearms&a=product_summary&s=19691
https://www.savagearms.com/content?p=firearms&a=product_summary&s=57425
I could not find an exact Savage 111F, or any 111 in .308 Win, so these figures are based on
the 110 Classic and the 111 Trophy Hunter XP in .30-06 Springfield.
FN SCAR H
https://en.wikipedia.org/wiki/FN_SCAR
https://www.fnherstal.com/sites/default/files/2020-06/technical-data-fn-scar-h_0.pdf
https://gunivore.com/rifle/fn-scar-rifle-overview-and-review/
HK417 A2
https://en.wikipedia.org/wiki/Heckler_%26_Koch_HK417
https://www.heckler-koch.com/en/products/military/assault-rifles/hk417/hk417-a2-165/technical-data.html
M110A1
https://en.wikipedia.org/wiki/M110_Semi-Automatic_Sniper_System
https://en.wikipedia.org/wiki/Heckler_%26_Koch_HK417#M110A1
https://www.heckler-koch.com/en/products/military/precision-rifles/g28/g28/overview.html
https://www.militaryfactory.com/smallarms/detail.asp?smallarms_id=246
AR-10
https://en.wikipedia.org/wiki/ArmaLite_AR-10