Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit guns in .30-06 for width, volume, and longest_side #42466

Merged
merged 5 commits into from
Jul 28, 2020

Conversation

feinorgh
Copy link
Contributor

@feinorgh feinorgh commented Jul 26, 2020

Summary

SUMMARY: Content "Audit guns in the .30-06 calibre for volume, weight, and longest_side"

Purpose of change

Contribute to completion of #41691 and #37374

Describe the solution

By using the method in #37374, go through the guns and calculate reasonable values.

Describe alternatives you've considered

Lie back, have a drink, and use 10 cm long rifles for fun and profit.

Testing

Test suite passes, and each updated weapon should spawn in the game with reasonable values.

Additional context

Browning BLR

This is based on the 22 inch barrel version of the Browning BLR Lightweight.

Source: https://docs.google.com/spreadsheets/d/10TeuTTjwusbWB9SaH-nq03bMWDyILylU9Btvtu3uTDM/edit#gid=93328453&range=A32

98 - Browning BLR

M1 Garand

Width calculated from a top view, with the profile area divided by the length, which makes the average width across the length 41.9 mm.

https://docs.google.com/spreadsheets/d/10TeuTTjwusbWB9SaH-nq03bMWDyILylU9Btvtu3uTDM/edit#gid=93328453&range=A85

99 - M1 Garand

M1903 Springfield

Width estimated from pictures, although no reliable source was found.

https://docs.google.com/spreadsheets/d/10TeuTTjwusbWB9SaH-nq03bMWDyILylU9Btvtu3uTDM/edit#gid=93328453&range=A90

100 - M1903 Springfield

Browning Automatic Rifle

This is assumed to be the M1918A2 (based on the weight of the weapon), developed for World War II service in 1938. Estimated average width from drawings is 2 inches. No definite source of width found.

https://docs.google.com/spreadsheets/d/10TeuTTjwusbWB9SaH-nq03bMWDyILylU9Btvtu3uTDM/edit#gid=93328453&range=A31

101 - Browning Automatic Rifle

Remington 700 .30-06

This is based on the Remington 700 SPS in .30-06. Width is based on an average width of the stock and handguard of 2.095 inches. Note that the Remington 700 in .270 have different values, but I think the different stock and handguards make a huge difference.

https://docs.google.com/spreadsheets/d/10TeuTTjwusbWB9SaH-nq03bMWDyILylU9Btvtu3uTDM/edit#gid=93328453&range=A150

102 - Remington 700  30-06

@anothersimulacrum anothersimulacrum added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items: Containers Things that hold other things labels Jul 26, 2020
@feinorgh feinorgh marked this pull request as ready for review July 26, 2020 18:46
@feinorgh feinorgh changed the title Audit guns in .30-06 for width, volume, and longest_width Audit guns in .30-06 for width, volume, and longest_side Jul 26, 2020
@ZhilkinSerg ZhilkinSerg merged commit 9ffd58c into CleverRaven:master Jul 28, 2020
@feinorgh feinorgh deleted the audit_3006_guns branch July 29, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants