Ammo extended effects loading issue repair #44750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothersimulacrum
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Ammo extended effects - factory loading."
Purpose of change
Fixes #42795
This was affecting all extended effects and delete effects for ammo that was copied from a base item. These properties were simply not loading so copied ammo would neither add or delete any effects.
The cause can be traced back to PR #39899.
Describe the solution
Reinstate the old method used before the refactoring.
Describe alternatives you've considered
Rewrite the method in the generic factory. This is easier.
Testing
Test firing of explosive ammo. Explosions now happen. Killed self with splash damage from firing at zombie too close.
Inspected item descriptions of various derived ammos, such as reloaded .50 cal. Properties are now as expected according to the extended effects and delete effects.
Additional context