Weakpoints (Part 2.1): Ignore weakpoints for item DPS calculations #51404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
<Bugfix>
|
Whew, thanks. That was bothering me and I've had no time to work on it at all. |
|
Hmm, I think this is not the ideal solution even as a stopgap as it's essentially just turning off the test entirely. What I think I'll do for the moment is generate a duplicate monster that has no weakpoints, and use that for the test. I'll add that to this PR myself if you've given me the ability, hold on. This solution isn't great either but it keeps the current utility of the test unchanged. If smoker or regular zombies get weak points we'll need to get smarter. |
Venera3
pushed a commit
to Venera3/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2021
…leverRaven#51404) * Ignore weakpoints for item DPS calculations * Increase epsilon between actual and expected DPS * Fix bug with rapid strike calculation * set effective_dps_test to use a test soldier * Update zed_soldiers.json Co-authored-by: I-am-Erk <45136638+I-am-Erk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Ignore weakpoints for item DPS calculations"
Purpose of change
The existing item DPS calculation assumes that a creatures armor has 100% coverage. The recent weak point changes will break that assumption.
Describe the solution
Inline the previous monster::absorb_hit definition into item::effective_dps. Temporarily increase the allowable difference between actual and calculated DPS.
This involves a static_cast, but all targets passed to effective_dps are currently monsters.
Describe alternatives you've considered
Eventually, the DPS calculation should consider weakpoints.
Testing
Additional context
See #51305